[2/2] nfsd4: stid display should preserve on-the-wire byte order
diff mbox series

Message ID 1589239036-17100-2-git-send-email-bfields@redhat.com
State New
Headers show
  • [1/2] nfsd4: common stateid-printing code
Related show

Commit Message

J. Bruce Fields May 11, 2020, 11:17 p.m. UTC
From: "J. Bruce Fields" <bfields@redhat.com>

When we decode the stateid we byte-swap si_generation.

But for simplicity's sake and ease of comparison with network traces,
it's better to display the whole thing in network order.

Reported-by: Scott Mayhew <smayhew@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
 fs/nfsd/nfs4state.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff mbox series

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index ded08aeae497..6fed3bf00ca7 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2424,7 +2424,8 @@  static void nfs4_show_owner(struct seq_file *s, struct nfs4_stateowner *oo)
 static void nfs4_show_stateid(struct seq_file *s, stateid_t *stid)
-	seq_printf(s, "0x%16phN", stid);
+	seq_printf(s, "0x%.8x", stid->si_generation);
+	seq_printf(s, "%12phN", &stid->si_opaque);
 static int nfs4_show_open(struct seq_file *s, struct nfs4_stid *st)