| Message ID | 1589267017-17294-4-git-send-email-dillon.minfei@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Enable ilitek ili9341 on stm32f429-disco board | expand |
On Tue, May 12, 2020 at 9:04 AM <dillon.minfei@gmail.com> wrote: > From: dillon min <dillon.minfei@gmail.com> > > Enable the ltdc & ili9341 on stm32429-disco board. > > Signed-off-by: dillon min <dillon.minfei@gmail.com> This mostly looks good but... > +&spi5 { > + status = "okay"; > + pinctrl-0 = <&spi5_pins>; > + pinctrl-names = "default"; > + #address-cells = <1>; > + #size-cells = <0>; > + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; > + dmas = <&dma2 3 2 0x400 0x0>, > + <&dma2 4 2 0x400 0x0>; > + dma-names = "rx", "tx"; These DMA assignments seem to be SoC things and should rather be in the DTS(I) file where &spi5 is defined, right? stm32f429.dtsi I suppose? It is likely the same no matter which device is using spi5. Yours, Linus Walleij
Hi, Linus, thanks for reviewing. On Thu, May 14, 2020 at 4:24 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Tue, May 12, 2020 at 9:04 AM <dillon.minfei@gmail.com> wrote: > > > From: dillon min <dillon.minfei@gmail.com> > > > > Enable the ltdc & ili9341 on stm32429-disco board. > > > > Signed-off-by: dillon min <dillon.minfei@gmail.com> > > This mostly looks good but... > > > +&spi5 { > > + status = "okay"; > > + pinctrl-0 = <&spi5_pins>; > > + pinctrl-names = "default"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; > > + dmas = <&dma2 3 2 0x400 0x0>, > > + <&dma2 4 2 0x400 0x0>; > > + dma-names = "rx", "tx"; > > These DMA assignments seem to be SoC things and should > rather be in the DTS(I) file where &spi5 is defined, right? > stm32f429.dtsi I suppose? > > It is likely the same no matter which device is using spi5. > > Yours, > Linus Walleij Yes, the dma assignments can be moved to stm32f429.dtsi file. i will change it. thanks. best regards. dillon,
On 5/14/20 10:24 AM, Linus Walleij wrote: > On Tue, May 12, 2020 at 9:04 AM <dillon.minfei@gmail.com> wrote: > >> From: dillon min <dillon.minfei@gmail.com> >> >> Enable the ltdc & ili9341 on stm32429-disco board. >> >> Signed-off-by: dillon min <dillon.minfei@gmail.com> > > This mostly looks good but... > >> +&spi5 { >> + status = "okay"; >> + pinctrl-0 = <&spi5_pins>; >> + pinctrl-names = "default"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; >> + dmas = <&dma2 3 2 0x400 0x0>, >> + <&dma2 4 2 0x400 0x0>; >> + dma-names = "rx", "tx"; > > These DMA assignments seem to be SoC things and should > rather be in the DTS(I) file where &spi5 is defined, right? > stm32f429.dtsi I suppose? I agree with Linus, DMA have to be defined in SoC dtsi. And if a board doesn't want to use it, we use the "delete-property". > > It is likely the same no matter which device is using spi5. > > Yours, > Linus Walleij >
Hi Alexandre, On Thu, May 14, 2020 at 8:53 PM Alexandre Torgue <alexandre.torgue@st.com> wrote: > > > > On 5/14/20 10:24 AM, Linus Walleij wrote: > > On Tue, May 12, 2020 at 9:04 AM <dillon.minfei@gmail.com> wrote: > > > >> From: dillon min <dillon.minfei@gmail.com> > >> > >> Enable the ltdc & ili9341 on stm32429-disco board. > >> > >> Signed-off-by: dillon min <dillon.minfei@gmail.com> > > > > This mostly looks good but... > > > >> +&spi5 { > >> + status = "okay"; > >> + pinctrl-0 = <&spi5_pins>; > >> + pinctrl-names = "default"; > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; > >> + dmas = <&dma2 3 2 0x400 0x0>, > >> + <&dma2 4 2 0x400 0x0>; > >> + dma-names = "rx", "tx"; > > > > These DMA assignments seem to be SoC things and should > > rather be in the DTS(I) file where &spi5 is defined, right? > > stm32f429.dtsi I suppose? > > I agree with Linus, DMA have to be defined in SoC dtsi. And if a board > doesn't want to use it, we use the "delete-property". Yes, will move to Soc dtsi in next submits. i'm working on write a v4l2-m2m driver for dma2d of stm32 to support pixel conversion alpha blending between foreground and background graphics. as you know, some soc's engineer trying to add this function to drm system. do you know st's planning about soc's hardware accelerator driver on stm32mp? such as chrom-art, will add to drm subsystem via ioctl to access, or to v4l2, thanks. > > > > > It is likely the same no matter which device is using spi5. > > > > Yours, > > Linus Walleij > >
On 5/14/20 3:07 PM, dillon min wrote: > Hi Alexandre, > > On Thu, May 14, 2020 at 8:53 PM Alexandre Torgue > <alexandre.torgue@st.com> wrote: >> >> >> On 5/14/20 10:24 AM, Linus Walleij wrote: >>> On Tue, May 12, 2020 at 9:04 AM <dillon.minfei@gmail.com> wrote: >>> >>>> From: dillon min <dillon.minfei@gmail.com> >>>> >>>> Enable the ltdc & ili9341 on stm32429-disco board. >>>> >>>> Signed-off-by: dillon min <dillon.minfei@gmail.com> >>> This mostly looks good but... >>> >>>> +&spi5 { >>>> + status = "okay"; >>>> + pinctrl-0 = <&spi5_pins>; >>>> + pinctrl-names = "default"; >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; >>>> + dmas = <&dma2 3 2 0x400 0x0>, >>>> + <&dma2 4 2 0x400 0x0>; >>>> + dma-names = "rx", "tx"; >>> These DMA assignments seem to be SoC things and should >>> rather be in the DTS(I) file where &spi5 is defined, right? >>> stm32f429.dtsi I suppose? >> I agree with Linus, DMA have to be defined in SoC dtsi. And if a board >> doesn't want to use it, we use the "delete-property". > Yes, will move to Soc dtsi in next submits. > > i'm working on write a v4l2-m2m driver for dma2d of stm32 to support > pixel conversion > alpha blending between foreground and background graphics. > > as you know, some soc's engineer trying to add this function to drm system. > > do you know st's planning about soc's hardware accelerator driver on stm32mp? > such as chrom-art, will add to drm subsystem via ioctl to access, or to v4l2, On stm32mp we do not plan to use chrom-art in drm or v4l2 because it does fit with userland way of working. We use the GPU to do conversion, scaling, blending and composition in only one go. As explain here [1] DRM subsytem it isn't a solution and v4l2-m2m isn't used in any mainline compositors like Weston or android surfaceflinger. Benjamin [1] https://www.phoronix.com/scan.php?page=news_item&px=Linux-DRM-No-2D-Accel-API > > thanks. > >>> It is likely the same no matter which device is using spi5. >>> >>> Yours, >>> Linus Walleij >>> > _______________________________________________ > Linux-stm32 mailing list > Linux-stm32@st-md-mailman.stormreply.com > https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32
Hi Benjamin, thanks for reply. On Fri, May 15, 2020 at 4:31 PM Benjamin GAIGNARD <benjamin.gaignard@st.com> wrote: > > > > On 5/14/20 3:07 PM, dillon min wrote: > > Hi Alexandre, > > > > On Thu, May 14, 2020 at 8:53 PM Alexandre Torgue > > <alexandre.torgue@st.com> wrote: > >> > >> > >> On 5/14/20 10:24 AM, Linus Walleij wrote: > >>> On Tue, May 12, 2020 at 9:04 AM <dillon.minfei@gmail.com> wrote: > >>> > >>>> From: dillon min <dillon.minfei@gmail.com> > >>>> > >>>> Enable the ltdc & ili9341 on stm32429-disco board. > >>>> > >>>> Signed-off-by: dillon min <dillon.minfei@gmail.com> > >>> This mostly looks good but... > >>> > >>>> +&spi5 { > >>>> + status = "okay"; > >>>> + pinctrl-0 = <&spi5_pins>; > >>>> + pinctrl-names = "default"; > >>>> + #address-cells = <1>; > >>>> + #size-cells = <0>; > >>>> + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; > >>>> + dmas = <&dma2 3 2 0x400 0x0>, > >>>> + <&dma2 4 2 0x400 0x0>; > >>>> + dma-names = "rx", "tx"; > >>> These DMA assignments seem to be SoC things and should > >>> rather be in the DTS(I) file where &spi5 is defined, right? > >>> stm32f429.dtsi I suppose? > >> I agree with Linus, DMA have to be defined in SoC dtsi. And if a board > >> doesn't want to use it, we use the "delete-property". > > Yes, will move to Soc dtsi in next submits. > > > > i'm working on write a v4l2-m2m driver for dma2d of stm32 to support > > pixel conversion > > alpha blending between foreground and background graphics. > > > > as you know, some soc's engineer trying to add this function to drm system. > > > > do you know st's planning about soc's hardware accelerator driver on stm32mp? > > such as chrom-art, will add to drm subsystem via ioctl to access, or to v4l2, > On stm32mp we do not plan to use chrom-art in drm or v4l2 because it > does fit > with userland way of working. We use the GPU to do conversion, scaling, > blending > and composition in only one go. > As explain here [1] DRM subsytem it isn't a solution and v4l2-m2m isn't > used in any > mainline compositors like Weston or android surfaceflinger. > > Benjamin > After check stm32mp's datasheets, they don't have chrom-art ip inside. sorry for didn't check it yet. for stm32h7 series with chrom-art, jpeg hardware accelerator inside. does st has plan to setup a driver to support it ? i prefer v4l2-m2m should be easier to implement it. co work with dcmi, fbdev. thanks. best regards. Dillon > [1] > https://www.phoronix.com/scan.php?page=news_item&px=Linux-DRM-No-2D-Accel-API > > > > thanks. > > > >>> It is likely the same no matter which device is using spi5. > >>> > >>> Yours, > >>> Linus Walleij > >>> > > _______________________________________________ > > Linux-stm32 mailing list > > Linux-stm32@st-md-mailman.stormreply.com > > https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32
On 5/15/20 11:24 AM, dillon min wrote: > Hi Benjamin, > > thanks for reply. > > On Fri, May 15, 2020 at 4:31 PM Benjamin GAIGNARD > <benjamin.gaignard@st.com> wrote: >> >> >> On 5/14/20 3:07 PM, dillon min wrote: >>> Hi Alexandre, >>> >>> On Thu, May 14, 2020 at 8:53 PM Alexandre Torgue >>> <alexandre.torgue@st.com> wrote: >>>> >>>> On 5/14/20 10:24 AM, Linus Walleij wrote: >>>>> On Tue, May 12, 2020 at 9:04 AM <dillon.minfei@gmail.com> wrote: >>>>> >>>>>> From: dillon min <dillon.minfei@gmail.com> >>>>>> >>>>>> Enable the ltdc & ili9341 on stm32429-disco board. >>>>>> >>>>>> Signed-off-by: dillon min <dillon.minfei@gmail.com> >>>>> This mostly looks good but... >>>>> >>>>>> +&spi5 { >>>>>> + status = "okay"; >>>>>> + pinctrl-0 = <&spi5_pins>; >>>>>> + pinctrl-names = "default"; >>>>>> + #address-cells = <1>; >>>>>> + #size-cells = <0>; >>>>>> + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; >>>>>> + dmas = <&dma2 3 2 0x400 0x0>, >>>>>> + <&dma2 4 2 0x400 0x0>; >>>>>> + dma-names = "rx", "tx"; >>>>> These DMA assignments seem to be SoC things and should >>>>> rather be in the DTS(I) file where &spi5 is defined, right? >>>>> stm32f429.dtsi I suppose? >>>> I agree with Linus, DMA have to be defined in SoC dtsi. And if a board >>>> doesn't want to use it, we use the "delete-property". >>> Yes, will move to Soc dtsi in next submits. >>> >>> i'm working on write a v4l2-m2m driver for dma2d of stm32 to support >>> pixel conversion >>> alpha blending between foreground and background graphics. >>> >>> as you know, some soc's engineer trying to add this function to drm system. >>> >>> do you know st's planning about soc's hardware accelerator driver on stm32mp? >>> such as chrom-art, will add to drm subsystem via ioctl to access, or to v4l2, >> On stm32mp we do not plan to use chrom-art in drm or v4l2 because it >> does fit >> with userland way of working. We use the GPU to do conversion, scaling, >> blending >> and composition in only one go. >> As explain here [1] DRM subsytem it isn't a solution and v4l2-m2m isn't >> used in any >> mainline compositors like Weston or android surfaceflinger. >> >> Benjamin >> > After check stm32mp's datasheets, they don't have chrom-art ip inside. sorry for > didn't check it yet. > > for stm32h7 series with chrom-art, jpeg hardware accelerator inside. > does st has plan to > setup a driver to support it ? i prefer v4l2-m2m should be easier to > implement it. > co work with dcmi, fbdev. ST doesn't plan to create a driver for chrom-art because nothing in mainline userland could use it. Benjamin > > thanks. > > best regards. > > Dillon >> [1] >> https://www.phoronix.com/scan.php?page=news_item&px=Linux-DRM-No-2D-Accel-API >>> thanks. >>> >>>>> It is likely the same no matter which device is using spi5. >>>>> >>>>> Yours, >>>>> Linus Walleij >>>>> >>> _______________________________________________ >>> Linux-stm32 mailing list >>> Linux-stm32@st-md-mailman.stormreply.com >>> https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32
Hi Benjamin, got it, thanks a lot. best regards Dillon On Fri, May 15, 2020 at 5:34 PM Benjamin GAIGNARD <benjamin.gaignard@st.com> wrote: > > > > On 5/15/20 11:24 AM, dillon min wrote: > > Hi Benjamin, > > > > thanks for reply. > > > > On Fri, May 15, 2020 at 4:31 PM Benjamin GAIGNARD > > <benjamin.gaignard@st.com> wrote: > >> > >> > >> On 5/14/20 3:07 PM, dillon min wrote: > >>> Hi Alexandre, > >>> > >>> On Thu, May 14, 2020 at 8:53 PM Alexandre Torgue > >>> <alexandre.torgue@st.com> wrote: > >>>> > >>>> On 5/14/20 10:24 AM, Linus Walleij wrote: > >>>>> On Tue, May 12, 2020 at 9:04 AM <dillon.minfei@gmail.com> wrote: > >>>>> > >>>>>> From: dillon min <dillon.minfei@gmail.com> > >>>>>> > >>>>>> Enable the ltdc & ili9341 on stm32429-disco board. > >>>>>> > >>>>>> Signed-off-by: dillon min <dillon.minfei@gmail.com> > >>>>> This mostly looks good but... > >>>>> > >>>>>> +&spi5 { > >>>>>> + status = "okay"; > >>>>>> + pinctrl-0 = <&spi5_pins>; > >>>>>> + pinctrl-names = "default"; > >>>>>> + #address-cells = <1>; > >>>>>> + #size-cells = <0>; > >>>>>> + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; > >>>>>> + dmas = <&dma2 3 2 0x400 0x0>, > >>>>>> + <&dma2 4 2 0x400 0x0>; > >>>>>> + dma-names = "rx", "tx"; > >>>>> These DMA assignments seem to be SoC things and should > >>>>> rather be in the DTS(I) file where &spi5 is defined, right? > >>>>> stm32f429.dtsi I suppose? > >>>> I agree with Linus, DMA have to be defined in SoC dtsi. And if a board > >>>> doesn't want to use it, we use the "delete-property". > >>> Yes, will move to Soc dtsi in next submits. > >>> > >>> i'm working on write a v4l2-m2m driver for dma2d of stm32 to support > >>> pixel conversion > >>> alpha blending between foreground and background graphics. > >>> > >>> as you know, some soc's engineer trying to add this function to drm system. > >>> > >>> do you know st's planning about soc's hardware accelerator driver on stm32mp? > >>> such as chrom-art, will add to drm subsystem via ioctl to access, or to v4l2, > >> On stm32mp we do not plan to use chrom-art in drm or v4l2 because it > >> does fit > >> with userland way of working. We use the GPU to do conversion, scaling, > >> blending > >> and composition in only one go. > >> As explain here [1] DRM subsytem it isn't a solution and v4l2-m2m isn't > >> used in any > >> mainline compositors like Weston or android surfaceflinger. > >> > >> Benjamin > >> > > After check stm32mp's datasheets, they don't have chrom-art ip inside. sorry for > > didn't check it yet. > > > > for stm32h7 series with chrom-art, jpeg hardware accelerator inside. > > does st has plan to > > setup a driver to support it ? i prefer v4l2-m2m should be easier to > > implement it. > > co work with dcmi, fbdev. > ST doesn't plan to create a driver for chrom-art because nothing in > mainline > userland could use it. > > Benjamin > > > > thanks. > > > > best regards. > > > > Dillon > >> [1] > >> https://www.phoronix.com/scan.php?page=news_item&px=Linux-DRM-No-2D-Accel-API > >>> thanks. > >>> > >>>>> It is likely the same no matter which device is using spi5. > >>>>> > >>>>> Yours, > >>>>> Linus Walleij > >>>>> > >>> _______________________________________________ > >>> Linux-stm32 mailing list > >>> Linux-stm32@st-md-mailman.stormreply.com > >>> https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32
diff --git a/arch/arm/boot/dts/stm32f429-disco.dts b/arch/arm/boot/dts/stm32f429-disco.dts index 30c0f67..4475e40 100644 --- a/arch/arm/boot/dts/stm32f429-disco.dts +++ b/arch/arm/boot/dts/stm32f429-disco.dts @@ -49,6 +49,8 @@ #include "stm32f429.dtsi" #include "stm32f429-pinctrl.dtsi" #include <dt-bindings/input/input.h> +#include <dt-bindings/interrupt-controller/irq.h> +#include <dt-bindings/gpio/gpio.h> / { model = "STMicroelectronics STM32F429i-DISCO board"; @@ -127,3 +129,40 @@ pinctrl-names = "default"; status = "okay"; }; + +<dc { + status = "okay"; + pinctrl-0 = <<dc_pins_f429_disco>; + pinctrl-names = "default"; + + port { + ltdc_out_rgb: endpoint { + remote-endpoint = <&panel_in_rgb>; + }; + }; +}; + +&spi5 { + status = "okay"; + pinctrl-0 = <&spi5_pins>; + pinctrl-names = "default"; + #address-cells = <1>; + #size-cells = <0>; + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; + dmas = <&dma2 3 2 0x400 0x0>, + <&dma2 4 2 0x400 0x0>; + dma-names = "rx", "tx"; + display: display@0{ + /* Connect panel-ilitek-9341 to stm32 via ltdc*/ + compatible = "st,sf-tc240t-9370-t"; + reg = <0>; + spi-3wire; + spi-max-frequency = <10000000>; + dc-gpios = <&gpiod 13 0>; + port { + panel_in_rgb: endpoint { + remote-endpoint = <<dc_out_rgb>; + }; + }; + }; +};