| Message ID | 20200513065656.2110441-3-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/14] cachefiles: switch to kernel_write | expand |
On Wed, 2020-05-13 at 08:56 +0200, Christoph Hellwig wrote: > While pipes don't really need sb_writers projection, __kernel_write > is an > interface better kept private, and the additional rw_verify_area does > not > hurt here. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Right, should be fine AFAICS. Acked-by: Ian Kent <raven@themaw.net> > --- > fs/autofs/waitq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/autofs/waitq.c b/fs/autofs/waitq.c > index b04c528b19d34..74c886f7c51cb 100644 > --- a/fs/autofs/waitq.c > +++ b/fs/autofs/waitq.c > @@ -53,7 +53,7 @@ static int autofs_write(struct autofs_sb_info *sbi, > > mutex_lock(&sbi->pipe_mutex); > while (bytes) { > - wr = __kernel_write(file, data, bytes, &file->f_pos); > + wr = kernel_write(file, data, bytes, &file->f_pos); > if (wr <= 0) > break; > data += wr;
diff --git a/fs/autofs/waitq.c b/fs/autofs/waitq.c index b04c528b19d34..74c886f7c51cb 100644 --- a/fs/autofs/waitq.c +++ b/fs/autofs/waitq.c @@ -53,7 +53,7 @@ static int autofs_write(struct autofs_sb_info *sbi, mutex_lock(&sbi->pipe_mutex); while (bytes) { - wr = __kernel_write(file, data, bytes, &file->f_pos); + wr = kernel_write(file, data, bytes, &file->f_pos); if (wr <= 0) break; data += wr;
While pipes don't really need sb_writers projection, __kernel_write is an interface better kept private, and the additional rw_verify_area does not hurt here. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/autofs/waitq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)