drm/imx: imx-ldb: Remove the leftover LVDS_BIT_MAP_SPWG/JEIDA enums
diff mbox series

Message ID 1589268078-19905-1-git-send-email-victor.liu@nxp.com
State New
Headers show
Series
  • drm/imx: imx-ldb: Remove the leftover LVDS_BIT_MAP_SPWG/JEIDA enums
Related show

Commit Message

Liu Ying May 12, 2020, 7:21 a.m. UTC
No one is using the LVDS_BIT_MAP_SPWG/JEIDA enums since a previous
commit which changes the imx_ldb_bit_mappings[] array definition,
so let's remove them.

Fixes: 5e501ed7253b ("drm/imx: imx-ldb: allow to determine bus format from the connected panel")
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: NXP Linux Team <linux-imx@nxp.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 drivers/gpu/drm/imx/imx-ldb.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Liu Ying May 28, 2020, 2:55 a.m. UTC | #1
Gentle ping...

On Tue, 2020-05-12 at 15:21 +0800, Liu Ying wrote:
> No one is using the LVDS_BIT_MAP_SPWG/JEIDA enums since a previous
> commit which changes the imx_ldb_bit_mappings[] array definition,
> so let's remove them.
> 
> Fixes: 5e501ed7253b ("drm/imx: imx-ldb: allow to determine bus format
> from the connected panel")
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
>  drivers/gpu/drm/imx/imx-ldb.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-
> ldb.c
> index 4da22a9..19a00eb 100644
> --- a/drivers/gpu/drm/imx/imx-ldb.c
> +++ b/drivers/gpu/drm/imx/imx-ldb.c
> @@ -477,11 +477,6 @@ static int imx_ldb_register(struct drm_device
> *drm,
>  	return 0;
>  }
>  
> -enum {
> -	LVDS_BIT_MAP_SPWG,
> -	LVDS_BIT_MAP_JEIDA
> -};
> -
>  struct imx_ldb_bit_mapping {
>  	u32 bus_format;
>  	u32 datawidth;
Marco Felsch May 28, 2020, 9:34 a.m. UTC | #2
Hi Liu,

pls check [1], I already send patches for it. Those stuck because we
need to verify Philipp's proposal.

[1] https://www.spinics.net/lists/arm-kernel/msg789309.html

Regards,
  Marco

On 20-05-28 10:55, Liu Ying wrote:
> Gentle ping...
> 
> On Tue, 2020-05-12 at 15:21 +0800, Liu Ying wrote:
> > No one is using the LVDS_BIT_MAP_SPWG/JEIDA enums since a previous
> > commit which changes the imx_ldb_bit_mappings[] array definition,
> > so let's remove them.
> > 
> > Fixes: 5e501ed7253b ("drm/imx: imx-ldb: allow to determine bus format
> > from the connected panel")
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > Cc: NXP Linux Team <linux-imx@nxp.com>
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> >  drivers/gpu/drm/imx/imx-ldb.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-
> > ldb.c
> > index 4da22a9..19a00eb 100644
> > --- a/drivers/gpu/drm/imx/imx-ldb.c
> > +++ b/drivers/gpu/drm/imx/imx-ldb.c
> > @@ -477,11 +477,6 @@ static int imx_ldb_register(struct drm_device
> > *drm,
> >  	return 0;
> >  }
> >  
> > -enum {
> > -	LVDS_BIT_MAP_SPWG,
> > -	LVDS_BIT_MAP_JEIDA
> > -};
> > -
> >  struct imx_ldb_bit_mapping {
> >  	u32 bus_format;
> >  	u32 datawidth;
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
Liu Ying May 28, 2020, 10:10 a.m. UTC | #3
Hi Macro,

On Thu, 2020-05-28 at 11:34 +0200, Marco Felsch wrote:
> Hi Liu,
> 
> pls check [1], I already send patches for it. Those stuck because we
> need to verify Philipp's proposal.

Yeah, '[PATCH 09/17] drm/imx: imx-ldb: remove useless enum' in your
patch series does the same thing as this patch does.  I'm fine to drop
this patch then.

Regarding Philipp's proposal on the use-after-free issue, we've got the
basically the same implemetation in downstream ldb driver to address
the issue.

Regards,
Liu Ying 

> 
> [1] 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.spinics.net%2Flists%2Farm-kernel%2Fmsg789309.html&amp;data=02%7C01%7Cvictor.liu%40nxp.com%7C8da3e383727f4fe1e0dd08d802ea5458%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637262552748306435&amp;sdata=DWN%2F3jRT07qmPWxlgSTuD9eRiRVoOHWGRmfrgj0ZA3A%3D&amp;reserved=0
> 
> Regards,
>   Marco
> 
> On 20-05-28 10:55, Liu Ying wrote:
> > Gentle ping...
> > 
> > On Tue, 2020-05-12 at 15:21 +0800, Liu Ying wrote:
> > > No one is using the LVDS_BIT_MAP_SPWG/JEIDA enums since a
> > > previous
> > > commit which changes the imx_ldb_bit_mappings[] array definition,
> > > so let's remove them.
> > > 
> > > Fixes: 5e501ed7253b ("drm/imx: imx-ldb: allow to determine bus
> > > format
> > > from the connected panel")
> > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > > Cc: NXP Linux Team <linux-imx@nxp.com>
> > > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > > ---
> > >  drivers/gpu/drm/imx/imx-ldb.c | 5 -----
> > >  1 file changed, 5 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/imx/imx-ldb.c
> > > b/drivers/gpu/drm/imx/imx-
> > > ldb.c
> > > index 4da22a9..19a00eb 100644
> > > --- a/drivers/gpu/drm/imx/imx-ldb.c
> > > +++ b/drivers/gpu/drm/imx/imx-ldb.c
> > > @@ -477,11 +477,6 @@ static int imx_ldb_register(struct
> > > drm_device
> > > *drm,
> > >  	return 0;
> > >  }
> > >  
> > > -enum {
> > > -	LVDS_BIT_MAP_SPWG,
> > > -	LVDS_BIT_MAP_JEIDA
> > > -};
> > > -
> > >  struct imx_ldb_bit_mapping {
> > >  	u32 bus_format;
> > >  	u32 datawidth;
> > 
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=02%7C01%7Cvictor.liu%40nxp.com%7C8da3e383727f4fe1e0dd08d802ea5458%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637262552748306435&amp;sdata=isO%2Fp5kg9qJ8%2FLg5zqI8XazuxwHr1hPjiyTHFhy0n2o%3D&amp;reserved=0
> >

Patch
diff mbox series

diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c
index 4da22a9..19a00eb 100644
--- a/drivers/gpu/drm/imx/imx-ldb.c
+++ b/drivers/gpu/drm/imx/imx-ldb.c
@@ -477,11 +477,6 @@  static int imx_ldb_register(struct drm_device *drm,
 	return 0;
 }
 
-enum {
-	LVDS_BIT_MAP_SPWG,
-	LVDS_BIT_MAP_JEIDA
-};
-
 struct imx_ldb_bit_mapping {
 	u32 bus_format;
 	u32 datawidth;