| Message ID | 6675cb952771a48a50b46bcf577e363fcf5d7b3b.1589375923.git.congdanhqx@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | CI: Enable t1509 on GitHub Actions and Travis | expand |
Đoàn Trần Công Danh <congdanhqx@gmail.com> writes: > git-init(1)'s messages is subjected to i18n. > They should be tested by test_i18n* family. > > Fix them. > > Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com> > --- > t/t1509-root-work-tree.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/t/t1509-root-work-tree.sh b/t/t1509-root-work-tree.sh > index 553a3f601b..fd2f7abf1c 100755 > --- a/t/t1509-root-work-tree.sh > +++ b/t/t1509-root-work-tree.sh > @@ -221,7 +221,7 @@ test_expect_success 'setup' ' > rm -rf /.git && > echo "Initialized empty Git repository in /.git/" > expected && > git init > result && > - test_cmp expected result > + test_i18ncmp expected result > ' > > test_vars 'auto gitdir, root' ".git" "/" "" > @@ -246,7 +246,7 @@ test_expect_success 'setup' ' > cd / && > echo "Initialized empty Git repository in /" > expected && > git init --bare > result && > - test_cmp expected result > + test_i18ncmp expected result > ' > > test_vars 'auto gitdir, root' "." "" "" OK. It shows how rarely (if ever) this test script is actually exercised that we need fixes like these. Well done. Thanks.
diff --git a/t/t1509-root-work-tree.sh b/t/t1509-root-work-tree.sh index 553a3f601b..fd2f7abf1c 100755 --- a/t/t1509-root-work-tree.sh +++ b/t/t1509-root-work-tree.sh @@ -221,7 +221,7 @@ test_expect_success 'setup' ' rm -rf /.git && echo "Initialized empty Git repository in /.git/" > expected && git init > result && - test_cmp expected result + test_i18ncmp expected result ' test_vars 'auto gitdir, root' ".git" "/" "" @@ -246,7 +246,7 @@ test_expect_success 'setup' ' cd / && echo "Initialized empty Git repository in /" > expected && git init --bare > result && - test_cmp expected result + test_i18ncmp expected result ' test_vars 'auto gitdir, root' "." "" ""
git-init(1)'s messages is subjected to i18n. They should be tested by test_i18n* family. Fix them. Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com> --- t/t1509-root-work-tree.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)