| Message ID | 20200514012655.127202-1-chentao107@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] scsi: ufs-mediatek: Make ufs_mtk_fixup_dev_quirks static | expand |
Hi Tao, On Thu, 2020-05-14 at 09:26 +0800, ChenTao wrote: > Fix the following warning: > > drivers/scsi/ufs/ufs-mediatek.c:585:6: warning: > symbol 'ufs_mtk_fixup_dev_quirks' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: ChenTao <chentao107@huawei.com> > --- > drivers/scsi/ufs/ufs-mediatek.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > index c543142554d3..73e4a4f9a3a2 100644 > --- a/drivers/scsi/ufs/ufs-mediatek.c > +++ b/drivers/scsi/ufs/ufs-mediatek.c > @@ -582,7 +582,7 @@ static int ufs_mtk_apply_dev_quirks(struct ufs_hba *hba) > return 0; > } > > -void ufs_mtk_fixup_dev_quirks(struct ufs_hba *hba) > +static void ufs_mtk_fixup_dev_quirks(struct ufs_hba *hba) > { > struct ufs_dev_info *dev_info = &hba->dev_info; > u16 mid = dev_info->wmanufacturerid; Thanks for fixing this. Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
On Thu, 14 May 2020 09:26:55 +0800, ChenTao wrote: > Fix the following warning: > > drivers/scsi/ufs/ufs-mediatek.c:585:6: warning: > symbol 'ufs_mtk_fixup_dev_quirks' was not declared. Should it be static? Applied to 5.8/scsi-queue, thanks! [1/1] scsi: ufs-mediatek: Make ufs_mtk_fixup_dev_quirks static https://git.kernel.org/mkp/scsi/c/21d2b76831fd
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c index c543142554d3..73e4a4f9a3a2 100644 --- a/drivers/scsi/ufs/ufs-mediatek.c +++ b/drivers/scsi/ufs/ufs-mediatek.c @@ -582,7 +582,7 @@ static int ufs_mtk_apply_dev_quirks(struct ufs_hba *hba) return 0; } -void ufs_mtk_fixup_dev_quirks(struct ufs_hba *hba) +static void ufs_mtk_fixup_dev_quirks(struct ufs_hba *hba) { struct ufs_dev_info *dev_info = &hba->dev_info; u16 mid = dev_info->wmanufacturerid;
Fix the following warning: drivers/scsi/ufs/ufs-mediatek.c:585:6: warning: symbol 'ufs_mtk_fixup_dev_quirks' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: ChenTao <chentao107@huawei.com> --- drivers/scsi/ufs/ufs-mediatek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)