diff mbox series

[2/4] blk-mq: remove a pointless queue enter pair in blk_mq_alloc_request

Message ID 20200516153430.294324-3-hch@lst.de (mailing list archive)
State New, archived
Headers show
Series [1/4] blk-mq: move the call to blk_queue_enter_live out of blk_mq_get_request | expand

Commit Message

Christoph Hellwig May 16, 2020, 3:34 p.m. UTC
No need for two queue references.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-mq.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Bart Van Assche May 16, 2020, 4:25 p.m. UTC | #1
On 2020-05-16 08:34, Christoph Hellwig wrote:
> No need for two queue references.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
diff mbox series

Patch

diff --git a/block/blk-mq.c b/block/blk-mq.c
index d2962863e629f..d96d3931f33e6 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -406,10 +406,7 @@  struct request *blk_mq_alloc_request(struct request_queue *q, unsigned int op,
 	if (ret)
 		return ERR_PTR(ret);
 
-	blk_queue_enter_live(q);
 	rq = blk_mq_get_request(q, NULL, &alloc_data);
-	blk_queue_exit(q);
-
 	if (!rq) {
 		blk_queue_exit(q);
 		return ERR_PTR(-EWOULDBLOCK);