diff mbox series

[3/4] blk-mq: remove a pointless queue enter pair in blk_mq_alloc_request_hctx

Message ID 20200516182801.482930-4-hch@lst.de (mailing list archive)
State New, archived
Headers show
Series [1/4] blk-mq: move the call to blk_queue_enter_live out of blk_mq_get_request | expand

Commit Message

Christoph Hellwig May 16, 2020, 6:28 p.m. UTC 
No need for two queue references.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-mq.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Bart Van Assche May 16, 2020, 6:44 p.m. UTC | #1 
On 2020-05-16 11:28, Christoph Hellwig wrote:
> No need for two queue references.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
diff mbox series

Patch

diff --git a/block/blk-mq.c b/block/blk-mq.c
index 4e62b97dceb48..b1c12de8926e3 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -455,10 +455,7 @@  struct request *blk_mq_alloc_request_hctx(struct request_queue *q,
 	alloc_data.ctx = __blk_mq_get_ctx(q, cpu);
 
 	ret = -EWOULDBLOCK;
-	blk_queue_enter_live(q);
 	rq = blk_mq_get_request(q, NULL, &alloc_data);
-	blk_queue_exit(q);
-
 	if (!rq)
 		goto out_queue_exit;
 	return rq;