| Message ID | 20200519074229.22308-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | edaa9c460996068a128775f58e71bcd104c8203e |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | dt-bindings: media: Add missing clock domain description | expand |
Hi Geert, On Tue, May 19, 2020 at 09:42:29AM +0200, Geert Uytterhoeven wrote: > make dtbs_check: > > arch/arm/boot/dts/r7s72100-genmai.dt.yaml: camera@e8210000: 'clocks', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+' > > Fix this by documenting the missing properties. > Update the example to match reality. Thanks for fixing this! Acked-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > > Fixes: 7f464532b05dadc8 ("dt-bindings: Add missing 'additionalProperties: false'") > Fixes: 58361eaa11d561f3 ("dt-bindings: media: renesas,ceu: Convert to yaml") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > .../devicetree/bindings/media/renesas,ceu.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/renesas,ceu.yaml b/Documentation/devicetree/bindings/media/renesas,ceu.yaml > index f2393458814ee08f..c7e1e4fe67e6696b 100644 > --- a/Documentation/devicetree/bindings/media/renesas,ceu.yaml > +++ b/Documentation/devicetree/bindings/media/renesas,ceu.yaml > @@ -27,6 +27,12 @@ properties: > interrupts: > maxItems: 1 > > + clocks: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > port: > type: object > additionalProperties: false > @@ -57,6 +63,8 @@ required: > - compatible > - reg > - interrupts > + - clocks > + - power-domains > - port > > additionalProperties: false > @@ -64,11 +72,14 @@ additionalProperties: false > examples: > - | > #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/r7s72100-clock.h> > > ceu: ceu@e8210000 { > reg = <0xe8210000 0x209c>; > compatible = "renesas,r7s72100-ceu"; > interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp6_clks R7S72100_CLK_CEU>; > + power-domains = <&cpg_clocks>; > > port { > ceu_in: endpoint { > -- > 2.17.1 >
On Tue, May 19, 2020 at 09:42:29AM +0200, Geert Uytterhoeven wrote: > make dtbs_check: > > arch/arm/boot/dts/r7s72100-genmai.dt.yaml: camera@e8210000: 'clocks', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+' > > Fix this by documenting the missing properties. > Update the example to match reality. > > Fixes: 7f464532b05dadc8 ("dt-bindings: Add missing 'additionalProperties: false'") The above is not a error in this commit. It just exposed an error in the binding. So I don't think Fixes is appropriate. I'll drop when applying. > Fixes: 58361eaa11d561f3 ("dt-bindings: media: renesas,ceu: Convert to yaml") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > .../devicetree/bindings/media/renesas,ceu.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+)
On Tue, 19 May 2020 09:42:29 +0200, Geert Uytterhoeven wrote: > make dtbs_check: > > arch/arm/boot/dts/r7s72100-genmai.dt.yaml: camera@e8210000: 'clocks', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+' > > Fix this by documenting the missing properties. > Update the example to match reality. > > Fixes: 7f464532b05dadc8 ("dt-bindings: Add missing 'additionalProperties: false'") > Fixes: 58361eaa11d561f3 ("dt-bindings: media: renesas,ceu: Convert to yaml") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > .../devicetree/bindings/media/renesas,ceu.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/media/renesas,ceu.yaml b/Documentation/devicetree/bindings/media/renesas,ceu.yaml index f2393458814ee08f..c7e1e4fe67e6696b 100644 --- a/Documentation/devicetree/bindings/media/renesas,ceu.yaml +++ b/Documentation/devicetree/bindings/media/renesas,ceu.yaml @@ -27,6 +27,12 @@ properties: interrupts: maxItems: 1 + clocks: + maxItems: 1 + + power-domains: + maxItems: 1 + port: type: object additionalProperties: false @@ -57,6 +63,8 @@ required: - compatible - reg - interrupts + - clocks + - power-domains - port additionalProperties: false @@ -64,11 +72,14 @@ additionalProperties: false examples: - | #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/r7s72100-clock.h> ceu: ceu@e8210000 { reg = <0xe8210000 0x209c>; compatible = "renesas,r7s72100-ceu"; interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp6_clks R7S72100_CLK_CEU>; + power-domains = <&cpg_clocks>; port { ceu_in: endpoint {
make dtbs_check: arch/arm/boot/dts/r7s72100-genmai.dt.yaml: camera@e8210000: 'clocks', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+' Fix this by documenting the missing properties. Update the example to match reality. Fixes: 7f464532b05dadc8 ("dt-bindings: Add missing 'additionalProperties: false'") Fixes: 58361eaa11d561f3 ("dt-bindings: media: renesas,ceu: Convert to yaml") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- .../devicetree/bindings/media/renesas,ceu.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+)