| Message ID | 20200520081157.24922-1-dinghao.liu@zju.edu.cn (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: sun8i-ss - fix runtime pm imbalance on error | expand |
diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c index 6b301afffd11..41841415ead6 100644 --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c @@ -571,8 +571,10 @@ static int sun8i_ss_probe(struct platform_device *pdev) goto error_alg; err = pm_runtime_get_sync(ss->dev); - if (err < 0) + if (err < 0) { + pm_runtime_put_sync(ss->dev); goto error_alg; + } v = readl(ss->base + SS_CTL_REG); v >>= SS_DIE_ID_SHIFT;
pm_runtime_get_sync() increments the runtime PM usage counter even it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)