| Message ID | 20200520123312.320281-3-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix role-switch selection in type-c drivers | expand |
On Wed, May 20, 2020 at 01:33:12PM +0100, Bryan O'Donoghue wrote: > kbuild found a compile error with recent additions to the tps6598x to add > role-switch notification support. Digging into that error it turns out we > needed to add "select USB_ROLE_SWITCH" to Kconfig. > > Adding "depends on USB_ROLE_SWITCH" as had previously been done for this > driver could still result in a link-time failure. > > This patch propagates the tps6598x fix to hd3ss3220. > > Fixes: da4b5d18dd94 ("usb: typec: add dependency for TYPEC_HD3SS3220") > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> NAK. This is a switch consumer not supplier. The switch may not be needed on every platform with this driver. > --- > drivers/usb/typec/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig > index a6cdf4ec0be6..8f84304802f4 100644 > --- a/drivers/usb/typec/Kconfig > +++ b/drivers/usb/typec/Kconfig > @@ -53,7 +53,7 @@ source "drivers/usb/typec/ucsi/Kconfig" > config TYPEC_HD3SS3220 > tristate "TI HD3SS3220 Type-C DRP Port controller driver" > depends on I2C > - depends on USB_ROLE_SWITCH > + select USB_ROLE_SWITCH > help > Say Y or M here if your system has TI HD3SS3220 Type-C DRP Port > controller driver. thanks,
diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig index a6cdf4ec0be6..8f84304802f4 100644 --- a/drivers/usb/typec/Kconfig +++ b/drivers/usb/typec/Kconfig @@ -53,7 +53,7 @@ source "drivers/usb/typec/ucsi/Kconfig" config TYPEC_HD3SS3220 tristate "TI HD3SS3220 Type-C DRP Port controller driver" depends on I2C - depends on USB_ROLE_SWITCH + select USB_ROLE_SWITCH help Say Y or M here if your system has TI HD3SS3220 Type-C DRP Port controller driver.
kbuild found a compile error with recent additions to the tps6598x to add role-switch notification support. Digging into that error it turns out we needed to add "select USB_ROLE_SWITCH" to Kconfig. Adding "depends on USB_ROLE_SWITCH" as had previously been done for this driver could still result in a link-time failure. This patch propagates the tps6598x fix to hd3ss3220. Fixes: da4b5d18dd94 ("usb: typec: add dependency for TYPEC_HD3SS3220") Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- drivers/usb/typec/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)