diff mbox series

rtw88: 8822c: fix missing brace warning for old compilers

Message ID 20200522035521.12295-1-yhchuang@realtek.com (mailing list archive)
State Accepted
Commit 4e1a341580f2e51f7d1c992b50c28a6c4a242f7f
Delegated to: Kalle Valo
Headers show
Series rtw88: 8822c: fix missing brace warning for old compilers | expand

Commit Message

Tony Chuang May 22, 2020, 3:55 a.m. UTC 
From: Yan-Hsuan Chuang <yhchuang@realtek.com>

For older versions of gcc, the array = {0}; will cause warnings:

drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function 'rtw8822c_power_trim':
>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
>> missing braces around initializer [-Wmissing-braces]
s8 bb_gain[2][8] = {0};
^
drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: (near
initialization for 'bb_gain[0]') [-Wmissing-braces]

Fixes: 5ad4d8957b69 ("rtw88: set power trim according to efuse PG values")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
---
 drivers/net/wireless/realtek/rtw88/rtw8822c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sebastian Andrzej Siewior May 28, 2020, 6:39 p.m. UTC | #1 
On 2020-05-22 11:55:21 [+0800], yhchuang@realtek.com wrote:
> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> 
> For older versions of gcc, the array = {0}; will cause warnings:

I wouldn't say older. I have here 9.3.0 and it does create the same
warning.

Anyway, 

Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Sebastian
Kalle Valo May 29, 2020, 3:18 p.m. UTC | #2 
Sebastian Andrzej Siewior <bigeasy@linutronix.de> writes:

> On 2020-05-22 11:55:21 [+0800], yhchuang@realtek.com wrote:
>> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>> 
>> For older versions of gcc, the array = {0}; will cause warnings:
>
> I wouldn't say older. I have here 9.3.0 and it does create the same
> warning.

Yeah, and usually it's best to specify the exact compiler version. "old"
and "new" are very relative terms :)
Kalle Valo May 29, 2020, 5:36 p.m. UTC | #3 
<yhchuang@realtek.com> wrote:

> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> 
> For older versions of gcc, the array = {0}; will cause warnings:
> 
> drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function 'rtw8822c_power_trim':
> >> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
> >> missing braces around initializer [-Wmissing-braces]
> s8 bb_gain[2][8] = {0};
> ^
> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: (near
> initialization for 'bb_gain[0]') [-Wmissing-braces]
> 
> Fixes: 5ad4d8957b69 ("rtw88: set power trim according to efuse PG values")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Patch applied to wireless-drivers-next.git, thanks.

4e1a341580f2 rtw88: 8822c: fix missing brace warning for old compilers
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
index 2cf1c1f0a639..c3d72ef611c6 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
@@ -1037,7 +1037,7 @@  static void rtw8822c_set_power_trim(struct rtw_dev *rtwdev, s8 bb_gain[2][8])
 static void rtw8822c_power_trim(struct rtw_dev *rtwdev)
 {
 	u8 pg_pwr = 0xff, i, path, idx;
-	s8 bb_gain[2][8] = {0};
+	s8 bb_gain[2][8] = {};
 	u16 rf_efuse_2g[3] = {PPG_2GL_TXAB, PPG_2GM_TXAB, PPG_2GH_TXAB};
 	u16 rf_efuse_5g[2][5] = {{PPG_5GL1_TXA, PPG_5GL2_TXA, PPG_5GM1_TXA,
 				  PPG_5GM2_TXA, PPG_5GH1_TXA},