| Message ID | 1590390705-22898-1-git-send-email-yangtiezhu@loongson.cn (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | video: fbdev: pxafb: Use correct return value for pxafb_probe() | expand |
On 5/25/20 9:11 AM, Tiezhu Yang wrote: > When call function devm_platform_ioremap_resource(), we should use IS_ERR() > to check the return value and return PTR_ERR() if failed. > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> Applied to drm-misc-next tree (patch should show up in v5.9), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/pxafb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c > index 00b96a7..423331c 100644 > --- a/drivers/video/fbdev/pxafb.c > +++ b/drivers/video/fbdev/pxafb.c > @@ -2305,7 +2305,7 @@ static int pxafb_probe(struct platform_device *dev) > fbi->mmio_base = devm_platform_ioremap_resource(dev, 0); > if (IS_ERR(fbi->mmio_base)) { > dev_err(&dev->dev, "failed to get I/O memory\n"); > - ret = -EBUSY; > + ret = PTR_ERR(fbi->mmio_base); > goto failed; > } > >
Hi Bart, On Mon, Jun 01, 2020 at 03:25:25PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On 5/25/20 9:11 AM, Tiezhu Yang wrote: > > When call function devm_platform_ioremap_resource(), we should use IS_ERR() > > to check the return value and return PTR_ERR() if failed. > > > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> > > Applied to drm-misc-next tree (patch should show up in v5.9), thanks. Thanks for going through all the backlog of patches in the fbdev area every once in a while! That kind of housekeeping work is often underappreciated, but rather important to keep the ship going. Cheers, Daniel PS: Of course also holds for everyone else doing this in other areas. fbdev simply stuck out just now catching up on mails. > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > > > --- > > drivers/video/fbdev/pxafb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c > > index 00b96a7..423331c 100644 > > --- a/drivers/video/fbdev/pxafb.c > > +++ b/drivers/video/fbdev/pxafb.c > > @@ -2305,7 +2305,7 @@ static int pxafb_probe(struct platform_device *dev) > > fbi->mmio_base = devm_platform_ioremap_resource(dev, 0); > > if (IS_ERR(fbi->mmio_base)) { > > dev_err(&dev->dev, "failed to get I/O memory\n"); > > - ret = -EBUSY; > > + ret = PTR_ERR(fbi->mmio_base); > > goto failed; > > } > > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index 00b96a7..423331c 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -2305,7 +2305,7 @@ static int pxafb_probe(struct platform_device *dev) fbi->mmio_base = devm_platform_ioremap_resource(dev, 0); if (IS_ERR(fbi->mmio_base)) { dev_err(&dev->dev, "failed to get I/O memory\n"); - ret = -EBUSY; + ret = PTR_ERR(fbi->mmio_base); goto failed; }
When call function devm_platform_ioremap_resource(), we should use IS_ERR() to check the return value and return PTR_ERR() if failed. Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> --- drivers/video/fbdev/pxafb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)