add I2C device and compatible ID
diff mbox series

Message ID 20200525101335.29130-1-wtli@nuvoton.com
State New
Headers show
Series
  • add I2C device and compatible ID
Related show

Commit Message

Seven Lee May 25, 2020, 10:13 a.m. UTC
The nau8810 driver can also compatible with nau8812 and nau8814.

Signed-off-by: Seven Lee <wtli@nuvoton.com>
---
 .../devicetree/bindings/sound/nau8812.txt        | 16 ++++++++++++++++
 .../devicetree/bindings/sound/nau8814.txt        | 16 ++++++++++++++++
 sound/soc/codecs/nau8810.c                       |  4 ++++
 3 files changed, 36 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/nau8812.txt
 create mode 100644 Documentation/devicetree/bindings/sound/nau8814.txt

Comments

Mark Brown May 25, 2020, 10:49 a.m. UTC | #1
On Mon, May 25, 2020 at 06:13:34PM +0800, Seven Lee wrote:
> The nau8810 driver can also compatible with nau8812 and nau8814.
> 
> Signed-off-by: Seven Lee <wtli@nuvoton.com>
> ---
>  .../devicetree/bindings/sound/nau8812.txt        | 16 ++++++++++++++++
>  .../devicetree/bindings/sound/nau8814.txt        | 16 ++++++++++++++++
>  sound/soc/codecs/nau8810.c                       |  4 ++++

If they're compatible you should add the additional IDs to the same
binding document rather than adding additional binding documents.

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/sound/nau8812.txt b/Documentation/devicetree/bindings/sound/nau8812.txt
new file mode 100644
index 000000000000..7aab29586a1f
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/nau8812.txt
@@ -0,0 +1,16 @@ 
+NAU8812 audio CODEC
+
+This device supports I2C only.
+
+Required properties:
+
+  - compatible : "nuvoton,nau8812"
+
+  - reg : the I2C address of the device.
+
+Example:
+
+codec: nau8812@1a {
+	compatible = "nuvoton,nau8812";
+	reg = <0x1a>;
+};
diff --git a/Documentation/devicetree/bindings/sound/nau8814.txt b/Documentation/devicetree/bindings/sound/nau8814.txt
new file mode 100644
index 000000000000..24bf2ba3d23b
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/nau8814.txt
@@ -0,0 +1,16 @@ 
+NAU8814 audio CODEC
+
+This device supports I2C only.
+
+Required properties:
+
+  - compatible : "nuvoton,nau8814"
+
+  - reg : the I2C address of the device.
+
+Example:
+
+codec: nau8814@1a {
+	compatible = "nuvoton,nau8814";
+	reg = <0x1a>;
+};
diff --git a/sound/soc/codecs/nau8810.c b/sound/soc/codecs/nau8810.c
index efe9fb3fb225..33ebc6398426 100644
--- a/sound/soc/codecs/nau8810.c
+++ b/sound/soc/codecs/nau8810.c
@@ -895,6 +895,8 @@  static int nau8810_i2c_probe(struct i2c_client *i2c,
 
 static const struct i2c_device_id nau8810_i2c_id[] = {
 	{ "nau8810", 0 },
+	{ "nau8812", 0 },
+	{ "nau8814", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, nau8810_i2c_id);
@@ -902,6 +904,8 @@  MODULE_DEVICE_TABLE(i2c, nau8810_i2c_id);
 #ifdef CONFIG_OF
 static const struct of_device_id nau8810_of_match[] = {
 	{ .compatible = "nuvoton,nau8810", },
+	{ .compatible = "nuvoton,nau8812", },
+	{ .compatible = "nuvoton,nau8814", },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, nau8810_of_match);