[1/2] dt-bindings: ASoC: renesas,rsnd: Add r8a7742 support
diff mbox series

Message ID 1590526904-13855-2-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com
State Accepted
Commit b6f10d3f2e6dfccf58c54e81c8af586b66a80ce4
Delegated to: Geert Uytterhoeven
Headers show
Series
  • RZ/G1H enable sound support
Related show

Commit Message

Lad Prabhakar May 26, 2020, 9:01 p.m. UTC
Document RZ/G1H (R8A7742) SoC bindings.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
---
 Documentation/devicetree/bindings/sound/renesas,rsnd.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Geert Uytterhoeven May 27, 2020, 7:38 a.m. UTC | #1
On Tue, May 26, 2020 at 11:02 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Document RZ/G1H (R8A7742) SoC bindings.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Mark Brown May 27, 2020, 11:25 a.m. UTC | #2
On Tue, May 26, 2020 at 10:01:43PM +0100, Lad Prabhakar wrote:

>  				  Examples with soctypes are:
> +				    - "renesas,rcar_sound-r8a7742" (RZ/G1H)
>  				    - "renesas,rcar_sound-r8a7743" (RZ/G1M)
>  				    - "renesas,rcar_sound-r8a7744" (RZ/G1N)
>  				    - "renesas,rcar_sound-r8a7745" (RZ/G1E)

I'd expect a matching patch adding this compatible to the driver.
Lad, Prabhakar May 27, 2020, 11:32 a.m. UTC | #3
Hi Mark,

Thank you for the review.

On Wed, May 27, 2020 at 12:25 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, May 26, 2020 at 10:01:43PM +0100, Lad Prabhakar wrote:
>
> >                                 Examples with soctypes are:
> > +                                 - "renesas,rcar_sound-r8a7742" (RZ/G1H)
> >                                   - "renesas,rcar_sound-r8a7743" (RZ/G1M)
> >                                   - "renesas,rcar_sound-r8a7744" (RZ/G1N)
> >                                   - "renesas,rcar_sound-r8a7745" (RZ/G1E)
>
> I'd expect a matching patch adding this compatible to the driver.

The Renesas R-Car sound for RZ/G1H is identical to the R-Car Gen2
family. So no driver change is needed and  the fallback compatible
value "renesas,rcar_sound-gen2" will be used in the SOC DT.

Cheers,
--Prabhakar Lad
Mark Brown May 27, 2020, 11:54 a.m. UTC | #4
On Wed, May 27, 2020 at 12:32:28PM +0100, Lad, Prabhakar wrote:
> On Wed, May 27, 2020 at 12:25 PM Mark Brown <broonie@kernel.org> wrote:

> > > +                                 - "renesas,rcar_sound-r8a7742" (RZ/G1H)

> > I'd expect a matching patch adding this compatible to the driver.

> The Renesas R-Car sound for RZ/G1H is identical to the R-Car Gen2
> family. So no driver change is needed and  the fallback compatible
> value "renesas,rcar_sound-gen2" will be used in the SOC DT.

Then the patch to add the compatible string will be trivial.
Rob Herring May 29, 2020, 5:50 p.m. UTC | #5
On Tue, 26 May 2020 22:01:43 +0100, Lad Prabhakar wrote:
> Document RZ/G1H (R8A7742) SoC bindings.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/sound/renesas,rsnd.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
index 797fd03..1596f0d 100644
--- a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
+++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
@@ -263,6 +263,7 @@  Required properties:
 				  "renesas,rcar_sound-gen2" if generation2 (or RZ/G1)
 				  "renesas,rcar_sound-gen3" if generation3 (or RZ/G2)
 				  Examples with soctypes are:
+				    - "renesas,rcar_sound-r8a7742" (RZ/G1H)
 				    - "renesas,rcar_sound-r8a7743" (RZ/G1M)
 				    - "renesas,rcar_sound-r8a7744" (RZ/G1N)
 				    - "renesas,rcar_sound-r8a7745" (RZ/G1E)