[v3] drm/panfrost: Reduce the amount of logs on deferred probe
diff mbox series

Message ID 20200527200544.7849-1-krzk@kernel.org
State New
Headers show
Series
  • [v3] drm/panfrost: Reduce the amount of logs on deferred probe
Related show

Commit Message

Krzysztof Kozlowski May 27, 2020, 8:05 p.m. UTC
There is no point to print deferred probe (and its failures to get
resources) as an error.  Also there is no need to print regulator errors
twice.

In case of multiple probe tries this would pollute the dmesg.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Steven Price <steven.price@arm.com>

---

Changes since v2:
1. Rebase
2. Add Steven's review

Changes since v1:
1. Remove second error message from calling panfrost_regulator_init()
---
 drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Alyssa Rosenzweig May 27, 2020, 8:43 p.m. UTC | #1
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>

On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote:
> There is no point to print deferred probe (and its failures to get
> resources) as an error.  Also there is no need to print regulator errors
> twice.
> 
> In case of multiple probe tries this would pollute the dmesg.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Steven Price <steven.price@arm.com>
> 
> ---
> 
> Changes since v2:
> 1. Rebase
> 2. Add Steven's review
> 
> Changes since v1:
> 1. Remove second error message from calling panfrost_regulator_init()
> ---
>  drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
> index 8136babd3ba9..b172087eee6a 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.c
> @@ -101,7 +101,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
>  				      pfdev->comp->num_supplies,
>  				      pfdev->regulators);
>  	if (ret < 0) {
> -		dev_err(pfdev->dev, "failed to get regulators: %d\n", ret);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(pfdev->dev, "failed to get regulators: %d\n",
> +				ret);
>  		return ret;
>  	}
>  
> @@ -213,10 +215,8 @@ int panfrost_device_init(struct panfrost_device *pfdev)
>  	}
>  
>  	err = panfrost_regulator_init(pfdev);
> -	if (err) {
> -		dev_err(pfdev->dev, "regulator init failed %d\n", err);
> +	if (err)
>  		goto err_out0;
> -	}
>  
>  	err = panfrost_reset_init(pfdev);
>  	if (err) {
> -- 
> 2.17.1
>
Krzysztof Kozlowski June 17, 2020, 2:15 p.m. UTC | #2
On Wed, May 27, 2020 at 04:43:34PM -0400, Alyssa Rosenzweig wrote:
> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
> 
> On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote:
> > There is no point to print deferred probe (and its failures to get
> > resources) as an error.  Also there is no need to print regulator errors
> > twice.
> > 
> > In case of multiple probe tries this would pollute the dmesg.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Reviewed-by: Steven Price <steven.price@arm.com>
> > 
> > ---
> > 
> > Changes since v2:
> > 1. Rebase
> > 2. Add Steven's review
> > 
> > Changes since v1:
> > 1. Remove second error message from calling panfrost_regulator_init()
> > ---
> >  drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 

Hi Rob, Tomeu and Steven,

You're listed as maintainers for panfrost. Is anyone going to pick this
up?

Maybe I sent it to wrong mailing list or forgot about anything?

Best regards,
Krzysztof
Steven Price June 17, 2020, 2:35 p.m. UTC | #3
On 17/06/2020 15:15, Krzysztof Kozlowski wrote:
> On Wed, May 27, 2020 at 04:43:34PM -0400, Alyssa Rosenzweig wrote:
>> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
>>
>> On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote:
>>> There is no point to print deferred probe (and its failures to get
>>> resources) as an error.  Also there is no need to print regulator errors
>>> twice.
>>>
>>> In case of multiple probe tries this would pollute the dmesg.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>> Reviewed-by: Steven Price <steven.price@arm.com>
>>>
>>> ---
>>>
>>> Changes since v2:
>>> 1. Rebase
>>> 2. Add Steven's review
>>>
>>> Changes since v1:
>>> 1. Remove second error message from calling panfrost_regulator_init()
>>> ---
>>>   drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
>>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>>
> 
> Hi Rob, Tomeu and Steven,
> 
> You're listed as maintainers for panfrost. Is anyone going to pick this
> up?

I'm only a reviewer so I've been leaving it for Rob or Tomeu, but I can 
pick it up if Rob/Tomeu are happy for me to do that.

> Maybe I sent it to wrong mailing list or forgot about anything?

No, there's actually a few Panfrost commits waiting, it was on my todo 
list to ask if Rob/Tomeu needed some help with merging patches.

Steve
Rob Herring June 17, 2020, 7:57 p.m. UTC | #4
On Wed, Jun 17, 2020 at 8:36 AM Steven Price <steven.price@arm.com> wrote:
>
> On 17/06/2020 15:15, Krzysztof Kozlowski wrote:
> > On Wed, May 27, 2020 at 04:43:34PM -0400, Alyssa Rosenzweig wrote:
> >> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
> >>
> >> On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote:
> >>> There is no point to print deferred probe (and its failures to get
> >>> resources) as an error.  Also there is no need to print regulator errors
> >>> twice.
> >>>
> >>> In case of multiple probe tries this would pollute the dmesg.
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >>> Reviewed-by: Steven Price <steven.price@arm.com>
> >>>
> >>> ---
> >>>
> >>> Changes since v2:
> >>> 1. Rebase
> >>> 2. Add Steven's review
> >>>
> >>> Changes since v1:
> >>> 1. Remove second error message from calling panfrost_regulator_init()
> >>> ---
> >>>   drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
> >>>   1 file changed, 4 insertions(+), 4 deletions(-)
> >>>
> >
> > Hi Rob, Tomeu and Steven,
> >
> > You're listed as maintainers for panfrost. Is anyone going to pick this
> > up?
>
> I'm only a reviewer so I've been leaving it for Rob or Tomeu, but I can
> pick it up if Rob/Tomeu are happy for me to do that.
>
> > Maybe I sent it to wrong mailing list or forgot about anything?
>
> No, there's actually a few Panfrost commits waiting, it was on my todo
> list to ask if Rob/Tomeu needed some help with merging patches.

Please do, I haven't had the cycles for panfrost lately.

Rob
Steven Price June 18, 2020, 9:28 a.m. UTC | #5
On 17/06/2020 20:57, Rob Herring wrote:
> On Wed, Jun 17, 2020 at 8:36 AM Steven Price <steven.price@arm.com> wrote:
>>
>> On 17/06/2020 15:15, Krzysztof Kozlowski wrote:
>>> On Wed, May 27, 2020 at 04:43:34PM -0400, Alyssa Rosenzweig wrote:
>>>> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
>>>>
>>>> On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote:
>>>>> There is no point to print deferred probe (and its failures to get
>>>>> resources) as an error.  Also there is no need to print regulator errors
>>>>> twice.
>>>>>
>>>>> In case of multiple probe tries this would pollute the dmesg.
>>>>>
>>>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>>>> Reviewed-by: Steven Price <steven.price@arm.com>
>>>>>
>>>>> ---
>>>>>
>>>>> Changes since v2:
>>>>> 1. Rebase
>>>>> 2. Add Steven's review
>>>>>
>>>>> Changes since v1:
>>>>> 1. Remove second error message from calling panfrost_regulator_init()
>>>>> ---
>>>>>    drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
>>>>>    1 file changed, 4 insertions(+), 4 deletions(-)
>>>>>
>>>
>>> Hi Rob, Tomeu and Steven,
>>>
>>> You're listed as maintainers for panfrost. Is anyone going to pick this
>>> up?
>>
>> I'm only a reviewer so I've been leaving it for Rob or Tomeu, but I can
>> pick it up if Rob/Tomeu are happy for me to do that.
>>
>>> Maybe I sent it to wrong mailing list or forgot about anything?
>>
>> No, there's actually a few Panfrost commits waiting, it was on my todo
>> list to ask if Rob/Tomeu needed some help with merging patches.
> 
> Please do, I haven't had the cycles for panfrost lately.
> 
> Rob
> 

Ok, this patch is pushed to drm-misc-next. I'll dig through my emails 
for the other patches which are pending and take a look at them too.

Steve

Patch
diff mbox series

diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
index 8136babd3ba9..b172087eee6a 100644
--- a/drivers/gpu/drm/panfrost/panfrost_device.c
+++ b/drivers/gpu/drm/panfrost/panfrost_device.c
@@ -101,7 +101,9 @@  static int panfrost_regulator_init(struct panfrost_device *pfdev)
 				      pfdev->comp->num_supplies,
 				      pfdev->regulators);
 	if (ret < 0) {
-		dev_err(pfdev->dev, "failed to get regulators: %d\n", ret);
+		if (ret != -EPROBE_DEFER)
+			dev_err(pfdev->dev, "failed to get regulators: %d\n",
+				ret);
 		return ret;
 	}
 
@@ -213,10 +215,8 @@  int panfrost_device_init(struct panfrost_device *pfdev)
 	}
 
 	err = panfrost_regulator_init(pfdev);
-	if (err) {
-		dev_err(pfdev->dev, "regulator init failed %d\n", err);
+	if (err)
 		goto err_out0;
-	}
 
 	err = panfrost_reset_init(pfdev);
 	if (err) {