| Message ID | 20200528072106.5191-1-dinghao.liu@zju.edu.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [v2] hwrng: ks-sa - Fix runtime PM imbalance on error | expand |
Hello Dinghao, On Thu, 2020-05-28 at 15:21 +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com> > --- > > Changelog: > > v2: - Use pm_runtime_put_noidle() instead of pm_runtime_put_sync(). > --- > drivers/char/hw_random/ks-sa-rng.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/hw_random/ks-sa-rng.c b/drivers/char/hw_random/ks-sa-rng.c > index e2330e757f1f..001617033d6a 100644 > --- a/drivers/char/hw_random/ks-sa-rng.c > +++ b/drivers/char/hw_random/ks-sa-rng.c > @@ -244,6 +244,7 @@ static int ks_sa_rng_probe(struct platform_device *pdev) > ret = pm_runtime_get_sync(dev); > if (ret < 0) { > dev_err(dev, "Failed to enable SA power-domain\n"); > + pm_runtime_put_noidle(dev); > pm_runtime_disable(dev); > return ret; > }
On Thu, May 28, 2020 at 03:21:04PM +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> > --- > > Changelog: > > v2: - Use pm_runtime_put_noidle() instead of pm_runtime_put_sync(). > --- > drivers/char/hw_random/ks-sa-rng.c | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks.
diff --git a/drivers/char/hw_random/ks-sa-rng.c b/drivers/char/hw_random/ks-sa-rng.c index e2330e757f1f..001617033d6a 100644 --- a/drivers/char/hw_random/ks-sa-rng.c +++ b/drivers/char/hw_random/ks-sa-rng.c @@ -244,6 +244,7 @@ static int ks_sa_rng_probe(struct platform_device *pdev) ret = pm_runtime_get_sync(dev); if (ret < 0) { dev_err(dev, "Failed to enable SA power-domain\n"); + pm_runtime_put_noidle(dev); pm_runtime_disable(dev); return ret; }
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- Changelog: v2: - Use pm_runtime_put_noidle() instead of pm_runtime_put_sync(). --- drivers/char/hw_random/ks-sa-rng.c | 1 + 1 file changed, 1 insertion(+)