| Message ID | 1590651179-5695-1-git-send-email-xuyang2018.jy@cn.fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | generic/484: add _require_xfs_io_command "syncfs" | expand |
On Thu, May 28, 2020 at 03:32:59PM +0800, Yang Xu wrote: > When using old xfsprogs version, xfs_io doesn't support syncfs command. > It was not fixed until xfsprogs commit eb24bcffc0("xfs_io: fix missing syncfs command"). > Add a require for this so that we can skip this case if xfs_io doesn't > support syncfs command. > > Reported-by: Feiyu Zhu <zhufy.jy@cn.fujitsu.com> > Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> > --- > tests/generic/484 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/generic/484 b/tests/generic/484 > index cf257c6b..dad411e9 100755 > --- a/tests/generic/484 > +++ b/tests/generic/484 > @@ -42,6 +42,7 @@ _require_scratch_nocheck > # realtime subvolume, thus the test will fail with rtinherit=1 > _require_no_rtinherit > _require_dm_target error > +_require_xfs_io_command "syncfs" That's good to me, as ext4/034 and generic/474 already had this 'requirement'. Reviewed-by: Zorro Lang <zlang@redhat.com> Thanks, Zorro > > rm -f $seqres.full > > -- > 2.23.0 > > >
diff --git a/tests/generic/484 b/tests/generic/484 index cf257c6b..dad411e9 100755 --- a/tests/generic/484 +++ b/tests/generic/484 @@ -42,6 +42,7 @@ _require_scratch_nocheck # realtime subvolume, thus the test will fail with rtinherit=1 _require_no_rtinherit _require_dm_target error +_require_xfs_io_command "syncfs" rm -f $seqres.full
When using old xfsprogs version, xfs_io doesn't support syncfs command. It was not fixed until xfsprogs commit eb24bcffc0("xfs_io: fix missing syncfs command"). Add a require for this so that we can skip this case if xfs_io doesn't support syncfs command. Reported-by: Feiyu Zhu <zhufy.jy@cn.fujitsu.com> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> --- tests/generic/484 | 1 + 1 file changed, 1 insertion(+)