[next] modpost: close file when fstat fails
diff mbox series

Message ID 20200528155443.421933-1-colin.king@canonical.com
State New
Headers show
Series
  • [next] modpost: close file when fstat fails
Related show

Commit Message

Colin Ian King May 28, 2020, 3:54 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

Currently a failed fstat error return path fails to close an open file.
Fix this by setting buf to NULL and returning via the error exit path.

Addresses-Coverity: ("Resource leak");
Fixes: commit 076ad831dfe8 ("modpost: add read_text_file() and get_line() helpers")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 scripts/mod/modpost.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Patch
diff mbox series

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index e4691127f051..3012e5f8ec7e 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -109,8 +109,10 @@  char *read_text_file(const char *filename)
 	if (fd < 0)
 		return NULL;
 
-	if (fstat(fd, &st) < 0)
-		return NULL;
+	if (fstat(fd, &st) < 0) {
+		buf = NULL;
+		goto close;
+	}
 
 	buf = NOFAIL(malloc(st.st_size + 1));