| Message ID | 20200528192112.26123-3-f.fainelli@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pinctrl: bcm2835: Support for wake-up interrupts | expand |
On Thu, May 28, 2020 at 12:21:10PM -0700, Florian Fainelli wrote: > BCM7211 supports wake-up interrupts in the form of optional interrupt > lines, one per bank, plus the "all banks" interrupt line. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > .../devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt b/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt > index dfc67b90591c..5682b2010e50 100644 > --- a/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt > +++ b/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt > @@ -16,7 +16,9 @@ Required properties: > second cell is used to specify optional parameters: > - bit 0 specifies polarity (0 for normal, 1 for inverted) > - interrupts : The interrupt outputs from the controller. One interrupt per > - individual bank followed by the "all banks" interrupt. > + individual bank followed by the "all banks" interrupt. For BCM7211, an > + additional set of per-bank interrupt line and an "all banks" wake-up > + interrupt may be specified. Is 'all banks' the name? Generally 'wakeup' is used for a wake up irq. Rob
On 5/29/20 12:33 PM, Rob Herring wrote: > On Thu, May 28, 2020 at 12:21:10PM -0700, Florian Fainelli wrote: >> BCM7211 supports wake-up interrupts in the form of optional interrupt >> lines, one per bank, plus the "all banks" interrupt line. >> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> >> --- >> .../devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt b/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt >> index dfc67b90591c..5682b2010e50 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt >> +++ b/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt >> @@ -16,7 +16,9 @@ Required properties: >> second cell is used to specify optional parameters: >> - bit 0 specifies polarity (0 for normal, 1 for inverted) >> - interrupts : The interrupt outputs from the controller. One interrupt per >> - individual bank followed by the "all banks" interrupt. >> + individual bank followed by the "all banks" interrupt. For BCM7211, an >> + additional set of per-bank interrupt line and an "all banks" wake-up >> + interrupt may be specified. > > Is 'all banks' the name? Generally 'wakeup' is used for a wake up irq. The firmware provided DTB on 7211 names the interrupts "gpio_%d" for the standard interrupts, including the "all banks" which is then "gpio_3" and the wake-up interrupts are named "gpio_%d_wake", and the all banks wake-up is "gpio_3_wake".
diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt b/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt index dfc67b90591c..5682b2010e50 100644 --- a/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt +++ b/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt @@ -16,7 +16,9 @@ Required properties: second cell is used to specify optional parameters: - bit 0 specifies polarity (0 for normal, 1 for inverted) - interrupts : The interrupt outputs from the controller. One interrupt per - individual bank followed by the "all banks" interrupt. + individual bank followed by the "all banks" interrupt. For BCM7211, an + additional set of per-bank interrupt line and an "all banks" wake-up + interrupt may be specified. - interrupt-controller: Marks the device node as an interrupt controller. - #interrupt-cells : Should be 2. The first cell is the GPIO number.
BCM7211 supports wake-up interrupts in the form of optional interrupt lines, one per bank, plus the "all banks" interrupt line. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- .../devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)