| Message ID | 1590723777-8718-1-git-send-email-hexiaoshuaishuai@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drivers/dax/bus: Use kobj_to_dev() API | expand |
On Fri, May 29, 2020 at 11:42:57AM +0800, Shuai He wrote: > Use kobj_to_dev() API instead of container_of(). > > Signed-off-by: Shuai He <hexiaoshuaishuai@gmail.com> Seems reasonable: Reviewed-by: Ira Weiny <ira.weiny@intel.com> > --- > drivers/dax/bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c > index df238c8..24625d2 100644 > --- a/drivers/dax/bus.c > +++ b/drivers/dax/bus.c > @@ -331,7 +331,7 @@ static DEVICE_ATTR_RO(numa_node); > > static umode_t dev_dax_visible(struct kobject *kobj, struct attribute *a, int n) > { > - struct device *dev = container_of(kobj, struct device, kobj); > + struct device *dev = kobj_to_dev(kobj); > struct dev_dax *dev_dax = to_dev_dax(dev); > > if (a == &dev_attr_target_node.attr && dev_dax_target_node(dev_dax) < 0) > -- > 2.7.4 > _______________________________________________ > Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org > To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
> Use kobj_to_dev() API instead of container_of(). > > Signed-off-by: Shuai He <hexiaoshuaishuai@gmail.com> > --- > drivers/dax/bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c > index df238c8..24625d2 100644 > --- a/drivers/dax/bus.c > +++ b/drivers/dax/bus.c > @@ -331,7 +331,7 @@ static DEVICE_ATTR_RO(numa_node); > > static umode_t dev_dax_visible(struct kobject *kobj, struct attribute *a, int n) > { > - struct device *dev = container_of(kobj, struct device, kobj); > + struct device *dev = kobj_to_dev(kobj); > struct dev_dax *dev_dax = to_dev_dax(dev); > > if (a == &dev_attr_target_node.attr && dev_dax_target_node(dev_dax) < 0) Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c index df238c8..24625d2 100644 --- a/drivers/dax/bus.c +++ b/drivers/dax/bus.c @@ -331,7 +331,7 @@ static DEVICE_ATTR_RO(numa_node); static umode_t dev_dax_visible(struct kobject *kobj, struct attribute *a, int n) { - struct device *dev = container_of(kobj, struct device, kobj); + struct device *dev = kobj_to_dev(kobj); struct dev_dax *dev_dax = to_dev_dax(dev); if (a == &dev_attr_target_node.attr && dev_dax_target_node(dev_dax) < 0)
Use kobj_to_dev() API instead of container_of(). Signed-off-by: Shuai He <hexiaoshuaishuai@gmail.com> --- drivers/dax/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)