diff mbox series

xen/build: fix xen/tools/binfile

Message ID 20200529182800.27555-1-jgross@suse.com (mailing list archive)
State New, archived
Headers show
Series xen/build: fix xen/tools/binfile | expand

Commit Message

Juergen Gross May 29, 2020, 6:28 p.m. UTC 
xen/tools/binfile contains a bash specific command (let). This leads
to build failures on systems not using bash as /bin/sh.

Replace "let SHIFT=$OPTIND-1" by "SHIFT=$((OPTIND-1))".

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/tools/binfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Cooper May 29, 2020, 9:32 p.m. UTC | #1 
On 29/05/2020 19:28, Juergen Gross wrote:
> xen/tools/binfile contains a bash specific command (let). This leads
> to build failures on systems not using bash as /bin/sh.
>
> Replace "let SHIFT=$OPTIND-1" by "SHIFT=$((OPTIND-1))".
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

A/T-by and pushed.  Thanks for the quick turnaround.

~Andrew
diff mbox series

Patch

diff --git a/xen/tools/binfile b/xen/tools/binfile
index df0301183f..23099c49bf 100755
--- a/xen/tools/binfile
+++ b/xen/tools/binfile
@@ -17,7 +17,7 @@  while getopts "ia:" opt; do
         ;;
     esac
 done
-let "SHIFT=$OPTIND-1"
+SHIFT=$((OPTIND-1))
 shift $SHIFT
 
 target=$1