[1/2] drm: panel-orientation-quirks: Add quirk for Asus T101HA panel
diff mbox series

Message ID 20200531093025.28050-1-hdegoede@redhat.com
State New
Headers show
Series
  • [1/2] drm: panel-orientation-quirks: Add quirk for Asus T101HA panel
Related show

Commit Message

Hans de Goede May 31, 2020, 9:30 a.m. UTC
Like the Asus T100HA the Asus T101HA also uses a panel which has been
mounted 90 degrees rotated, add a quirk for this.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Emil Velikov May 31, 2020, 5:25 p.m. UTC | #1
On Sun, 31 May 2020 at 10:30, Hans de Goede <hdegoede@redhat.com> wrote:
>
> Like the Asus T100HA the Asus T101HA also uses a panel which has been
> mounted 90 degrees rotated, add a quirk for this.
>
Reading the commit message, made me wonder: If it's similar why it
doesn't use the same quirk?
Something like the following helps:

... 90 degrees rotated, albeit in the opposite direction. Add a quirk for this.

With that the series is:
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

-Emil
Hans de Goede June 23, 2020, 11:04 a.m. UTC | #2
Hi,

On 5/31/20 7:25 PM, Emil Velikov wrote:
> On Sun, 31 May 2020 at 10:30, Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Like the Asus T100HA the Asus T101HA also uses a panel which has been
>> mounted 90 degrees rotated, add a quirk for this.
>>
> Reading the commit message, made me wonder: If it's similar why it
> doesn't use the same quirk?
> Something like the following helps:
> 
> ... 90 degrees rotated, albeit in the opposite direction. Add a quirk for this.
> 
> With that the series is:
> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

Thank you, I've ammended the commit msg with your suggestion
and pushed the 2 patches to drm-misc-fixes.

Regards,

Hans

Patch
diff mbox series

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index ffd95bfeaa94..d11d83703931 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -121,6 +121,12 @@  static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"),
 		},
 		.driver_data = (void *)&asus_t100ha,
+	}, {	/* Asus T101HA */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T101HA"),
+		},
+		.driver_data = (void *)&lcd800x1280_rightside_up,
 	}, {	/* GPD MicroPC (generic strings, also match on bios date) */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),