| Message ID | 20200531172804.256335-5-konradybcio@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | msm8992 DTS updates, peripheral enablement | expand |
On Sun, May 31, 2020 at 10:28 AM Konrad Dybcio <konradybcio@gmail.com> wrote: > > This change adds a compatible for msm8992, > which requires no additional clocks for > scm to probe correctly. > > Signed-off-by: Konrad Dybcio <konradybcio@gmail.com> > --- > drivers/firmware/qcom_scm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > index 059bb0fbae9e..4ee94c2ff5c0 100644 > --- a/drivers/firmware/qcom_scm.c > +++ b/drivers/firmware/qcom_scm.c > @@ -1154,6 +1154,7 @@ static const struct of_device_id qcom_scm_dt_match[] = { > SCM_HAS_IFACE_CLK | > SCM_HAS_BUS_CLK) > }, > + { .compatible = "qcom,scm-msm8992" }, As this is equivalent to "qcom,scm" use the form: compatible = "qcom,scm-msm8992", "qcom,scm"; I do however believe you still need to post a patch for the DT binding, to allow the checkers to accept "qcom,scm-msm8992". Regards, Bjorn > { .compatible = "qcom,scm-msm8996" }, > { .compatible = "qcom,scm" }, > {} > -- > 2.26.2 >
I have in fact submitted a binding patch here: [1] Perhaps I shouldn't have split it since it's just a one-liner. [1] https://patchwork.kernel.org/patch/11580841/ Regards Konrad
diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index 059bb0fbae9e..4ee94c2ff5c0 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -1154,6 +1154,7 @@ static const struct of_device_id qcom_scm_dt_match[] = { SCM_HAS_IFACE_CLK | SCM_HAS_BUS_CLK) }, + { .compatible = "qcom,scm-msm8992" }, { .compatible = "qcom,scm-msm8996" }, { .compatible = "qcom,scm" }, {}
This change adds a compatible for msm8992, which requires no additional clocks for scm to probe correctly. Signed-off-by: Konrad Dybcio <konradybcio@gmail.com> --- drivers/firmware/qcom_scm.c | 1 + 1 file changed, 1 insertion(+)