[2/3] arm64: dts: imx8qxp: add i2c aliases
diff mbox series

Message ID 1590977180-9957-3-git-send-email-peng.fan@nxp.com
State New
Headers show
Series
  • arm64: dts: imx8qxp: dtb aliases fix/update
Related show

Commit Message

Peng Fan June 1, 2020, 2:06 a.m. UTC
From: Peng Fan <peng.fan@nxp.com>

The devices could be enumerated properly with aliases.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Shawn Guo June 23, 2020, 3:56 a.m. UTC | #1
On Mon, Jun 01, 2020 at 10:06:19AM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The devices could be enumerated properly with aliases.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 33363c127478..8ce997110cd6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -19,6 +19,10 @@
>  	#size-cells = <2>;
>  
>  	aliases {
> +		i2c0 = &adma_i2c0;
> +		i2c1 = &adma_i2c1;
> +		i2c2 = &adma_i2c2;
> +		i2c3 = &adma_i2c3;

Had a second look.  It breaks alphabetical order.  So dropped the
series.

Shawn

>  		gpio0 = &lsio_gpio0;
>  		gpio1 = &lsio_gpio1;
>  		gpio2 = &lsio_gpio2;
> -- 
> 2.16.4
>
Peng Fan June 23, 2020, 7:06 a.m. UTC | #2
Hi Shawn,

> Subject: Re: [PATCH 2/3] arm64: dts: imx8qxp: add i2c aliases
> 
> On Mon, Jun 01, 2020 at 10:06:19AM +0800, peng.fan@nxp.com wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > The devices could be enumerated properly with aliases.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > index 33363c127478..8ce997110cd6 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > @@ -19,6 +19,10 @@
> >  	#size-cells = <2>;
> >
> >  	aliases {
> > +		i2c0 = &adma_i2c0;
> > +		i2c1 = &adma_i2c1;
> > +		i2c2 = &adma_i2c2;
> > +		i2c3 = &adma_i2c3;
> 
> Had a second look.  It breaks alphabetical order.  So dropped the series.

V2 has this addressed.
https://patchwork.kernel.org/cover/11619867/

Thanks,
Peng.

> 
> Shawn
> 
> >  		gpio0 = &lsio_gpio0;
> >  		gpio1 = &lsio_gpio1;
> >  		gpio2 = &lsio_gpio2;
> > --
> > 2.16.4
> >

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
index 33363c127478..8ce997110cd6 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
@@ -19,6 +19,10 @@ 
 	#size-cells = <2>;
 
 	aliases {
+		i2c0 = &adma_i2c0;
+		i2c1 = &adma_i2c1;
+		i2c2 = &adma_i2c2;
+		i2c3 = &adma_i2c3;
 		gpio0 = &lsio_gpio0;
 		gpio1 = &lsio_gpio1;
 		gpio2 = &lsio_gpio2;