selftests/seccomp: use 90s as timeout
diff mbox series

Message ID 20200601123202.1183526-1-cascardo@canonical.com
State New
Headers show
Series
  • selftests/seccomp: use 90s as timeout
Related show

Commit Message

Thadeu Lima de Souza Cascardo June 1, 2020, 12:32 p.m. UTC
As seccomp_benchmark tries to calibrate how many samples will take more
than 5 seconds to execute, it may end up picking up a number of samples
that take 10 (but up to 12) seconds. As the calibration will take double
that time, it takes around 20 seconds. Then, it executes the whole thing
again, and then once more, with some added overhead. So, the thing might
take more than 40 seconds, which is too close to the 45s timeout.

That is very dependent on the system where it's executed, so may not be
observed always, but it has been observed on x86 VMs. Using a 90s timeout
seems safe enough.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
---
 tools/testing/selftests/seccomp/settings | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kees Cook June 1, 2020, 7:49 p.m. UTC | #1
On Mon, Jun 01, 2020 at 09:32:02AM -0300, Thadeu Lima de Souza Cascardo wrote:
> As seccomp_benchmark tries to calibrate how many samples will take more
> than 5 seconds to execute, it may end up picking up a number of samples
> that take 10 (but up to 12) seconds. As the calibration will take double
> that time, it takes around 20 seconds. Then, it executes the whole thing
> again, and then once more, with some added overhead. So, the thing might
> take more than 40 seconds, which is too close to the 45s timeout.
> 
> That is very dependent on the system where it's executed, so may not be
> observed always, but it has been observed on x86 VMs. Using a 90s timeout
> seems safe enough.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>

Excellent point! Thanks, I've applied this (well, actually, your v2)
to for-next/seccomp.

Patch
diff mbox series

diff --git a/tools/testing/selftests/seccomp/settings b/tools/testing/selftests/seccomp/settings
index d61f00d8cad3..ba4d85f74cd6 100644
--- a/tools/testing/selftests/seccomp/settings
+++ b/tools/testing/selftests/seccomp/settings
@@ -1 +1 @@ 
-90
+timeout=90