From patchwork Mon Jun 1 13:03:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pali_Roh=C3=A1r?= X-Patchwork-Id: 11582009 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3AC20913 for ; Mon, 1 Jun 2020 13:03:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 173252068D for ; Mon, 1 Jun 2020 13:03:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Bp7YPqoX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="IqMBJBhQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 173252068D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=8f5BhPRHQzeq8ktQQx/4oHIi9EoJSNmpEhUI22C8Vr4=; b=Bp7YPqoXZxgVcX orfZm90RGx5hHV38bVyPMd82d16ieaqF2ZY6p0B7k0RCKDyEPJlSB9IBYeNWni3thzgUAioNvyL6e qnA1hWp6ybOKvZ6z0Zd3R+5T9XP7VTM+wAJ2TREex/ZNmQB4axJgLBMsLZpK6Ayri4XdC6XQ8nXAb HrP6r8P7MRe91uGFacb8D6BLqH0WsF/0hAAPf+3jk+0w4CcL4ea8Ei/C4lB/6jC3w3w5hWGSVjnAY bbe0aC6VOs140vhJEwljr8VuNIeM4DbSEux8vLDmdHItmBWLvt5h6TQemj2wzSA2Vd17SfT9a5TWQ MFqmP72TZfPOQbPoxC+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jfk6S-0001kw-JQ; Mon, 01 Jun 2020 13:03:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jfk6P-0001jr-J9 for linux-arm-kernel@lists.infradead.org; Mon, 01 Jun 2020 13:03:42 +0000 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 87BFE2068D; Mon, 1 Jun 2020 13:03:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591016620; bh=3xN+KUHay1UXrM2e/q9Ewz774/uNEpSlG4BqrojgmRI=; h=From:To:Cc:Subject:Date:From; b=IqMBJBhQg9sgMy1Kj9AZ4jYM8Ip+nSuoT3fd6gBMgEx80FyJItuwxsBcoenoDpY15 VOIxthju/gClsXmTLYHVrge9bc6iuzuFZmvQFnjq28zVFeYWP6rMrt1sXlnyOhrIDs WBGXWie/++Uuu/wovmm60x9u68QpuN24q8oiSnw8= Received: by pali.im (Postfix) id BA9BDCB0; Mon, 1 Jun 2020 15:03:38 +0200 (CEST) From: =?utf-8?q?Pali_Roh=C3=A1r?= To: Bjorn Helgaas , Thomas Petazzoni , Lorenzo Pieralisi , Andrew Murray , =?utf-8?q?Marek_Beh=C3=BAn?= , Remi Pommarel , Tomasz Maciej Nowak , Xogium Subject: [PATCH] PCI: aardvark: Indicate error in 'val' when config read fails Date: Mon, 1 Jun 2020 15:03:15 +0200 Message-Id: <20200601130315.18895-1-pali@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200601_060341_653416_77591E13 X-CRM114-Status: GOOD ( 12.48 ) X-Spam-Score: -5.2 (-----) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (-5.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [198.145.29.99 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Most callers of config read do not check for return value. But most of the ones that do, checks for error indication in 'val' variable. This patch updates error handling in advk_pcie_rd_conf() function. If PIO transfer fails then 'val' variable is set to 0xffffffff which indicates failture. Signed-off-by: Pali Rohár Reported-by: Bjorn Helgaas --- drivers/pci/controller/pci-aardvark.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index 53a4cfd7d377..783a7f1f2c44 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -691,8 +691,10 @@ static int advk_pcie_rd_conf(struct pci_bus *bus, u32 devfn, advk_writel(pcie, 1, PIO_START); ret = advk_pcie_wait_pio(pcie); - if (ret < 0) + if (ret < 0) { + *val = 0xffffffff; return PCIBIOS_SET_FAILED; + } advk_pcie_check_pio_status(pcie);