diff mbox series

drm/i915/params: fix i915.reset module param type

Message ID 20200602151126.25626-1-jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/params: fix i915.reset module param type | expand

Commit Message

Jani Nikula June 2, 2020, 3:11 p.m. UTC
The reset member in i915_params was previously changed to unsigned, but
this failed to change the actual module parameter.

Fixes: aae970d8454b ("drm/i915: Mark i915.reset as unsigned")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/i915_params.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chris Wilson June 2, 2020, 3:16 p.m. UTC | #1
Quoting Jani Nikula (2020-06-02 16:11:26)
> The reset member in i915_params was previously changed to unsigned, but
> this failed to change the actual module parameter.
> 
> Fixes: aae970d8454b ("drm/i915: Mark i915.reset as unsigned")
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
Jani Nikula June 4, 2020, 9:31 a.m. UTC | #2
On Tue, 02 Jun 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2020-06-02 16:11:26)
>> The reset member in i915_params was previously changed to unsigned, but
>> this failed to change the actual module parameter.
>> 
>> Fixes: aae970d8454b ("drm/i915: Mark i915.reset as unsigned")
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks, pushed.

BR,
Jani.
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index ace44ad7e6df..fd3b14caf4ce 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -74,7 +74,7 @@  i915_param_named_unsafe(vbt_sdvo_panel_type, int, 0400,
 	"Override/Ignore selection of SDVO panel mode in the VBT "
 	"(-2=ignore, -1=auto [default], index in VBT BIOS table)");
 
-i915_param_named_unsafe(reset, int, 0400,
+i915_param_named_unsafe(reset, uint, 0400,
 	"Attempt GPU resets (0=disabled, 1=full gpu reset, 2=engine reset [default])");
 
 i915_param_named_unsafe(vbt_firmware, charp, 0400,