| Message ID | 20200603092459.1424093-1-hslester96@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALSA: es1688: Add the missed snd_card_free() | expand |
On Wed, 03 Jun 2020 11:24:59 +0200, Chuhong Yuan wrote: > > snd_es968_pnp_detect() misses a snd_card_free() in a failed path. > Add the missed function call to fix it. > > Fixes: a20971b201ac ("ALSA: Merge es1688 and es968 drivers") > Signed-off-by: Chuhong Yuan <hslester96@gmail.com> Thanks, applied now with Cc-to-stable. Takashi
diff --git a/sound/isa/es1688/es1688.c b/sound/isa/es1688/es1688.c index ff3a05ad99c0..64610571a5e1 100644 --- a/sound/isa/es1688/es1688.c +++ b/sound/isa/es1688/es1688.c @@ -267,8 +267,10 @@ static int snd_es968_pnp_detect(struct pnp_card_link *pcard, return error; } error = snd_es1688_probe(card, dev); - if (error < 0) + if (error < 0) { + snd_card_free(card); return error; + } pnp_set_card_drvdata(pcard, card); snd_es968_pnp_is_probed = 1; return 0;
snd_es968_pnp_detect() misses a snd_card_free() in a failed path. Add the missed function call to fix it. Fixes: a20971b201ac ("ALSA: Merge es1688 and es968 drivers") Signed-off-by: Chuhong Yuan <hslester96@gmail.com> --- sound/isa/es1688/es1688.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)