| Message ID | 20200603114023.175102-6-alexandru.ardelean@analog.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: core: pass parent device as parameter during allocation | expand |
On Wed, 3 Jun 2020 14:40:22 +0300 Alexandru Ardelean <alexandru.ardelean@analog.com> wrote: > This assignment is the more peculiar as it assigns the parent of the > platform-device's device (i.e. pdev->dev.parent) as the IIO device's > parent. > > Since the devm_iio_device_alloc() [now] assigns the device argument as the > default parent (and since this is the more common case), for cases > where the parent needs to be different, the iio_device_set_parent helper > should be used. > > That makes things a bit more obvious about the new behavior of > devm_iio_device_alloc() and makes it clearer that iio_device_set_parent() > should be used. > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Applied. Thanks, Jonathan > --- > drivers/iio/light/lm3533-als.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c > index bc196c212881..8a621244dd01 100644 > --- a/drivers/iio/light/lm3533-als.c > +++ b/drivers/iio/light/lm3533-als.c > @@ -852,7 +852,7 @@ static int lm3533_als_probe(struct platform_device *pdev) > indio_dev->channels = lm3533_als_channels; > indio_dev->num_channels = ARRAY_SIZE(lm3533_als_channels); > indio_dev->name = dev_name(&pdev->dev); > - indio_dev->dev.parent = pdev->dev.parent; > + iio_device_set_parent(indio_dev, pdev->dev.parent); > indio_dev->modes = INDIO_DIRECT_MODE; > > als = iio_priv(indio_dev);
diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c index bc196c212881..8a621244dd01 100644 --- a/drivers/iio/light/lm3533-als.c +++ b/drivers/iio/light/lm3533-als.c @@ -852,7 +852,7 @@ static int lm3533_als_probe(struct platform_device *pdev) indio_dev->channels = lm3533_als_channels; indio_dev->num_channels = ARRAY_SIZE(lm3533_als_channels); indio_dev->name = dev_name(&pdev->dev); - indio_dev->dev.parent = pdev->dev.parent; + iio_device_set_parent(indio_dev, pdev->dev.parent); indio_dev->modes = INDIO_DIRECT_MODE; als = iio_priv(indio_dev);
This assignment is the more peculiar as it assigns the parent of the platform-device's device (i.e. pdev->dev.parent) as the IIO device's parent. Since the devm_iio_device_alloc() [now] assigns the device argument as the default parent (and since this is the more common case), for cases where the parent needs to be different, the iio_device_set_parent helper should be used. That makes things a bit more obvious about the new behavior of devm_iio_device_alloc() and makes it clearer that iio_device_set_parent() should be used. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> --- drivers/iio/light/lm3533-als.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)