| Message ID | 20200603121506.49992-6-tz.stoyanov@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | New trace-cmd "set" command and changes in "start" | expand |
On Wed, 3 Jun 2020 15:15:06 +0300 "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote: > --- a/tracecmd/trace-usage.c > +++ b/tracecmd/trace-usage.c > @@ -53,6 +53,7 @@ static struct usage_help usage_help[] = { > " --module filter module name\n" > " --by-comm used with --profile, merge events for related comms\n" > " --profile enable tracing options needed for report --profile\n" > + " -G when profiling, set soft and hard irqs as global\n" This should be in with the other "simple" options (those with a single character). The long options "--foo" should always be at the end after all simple ones. Thanks! -- Steve > " --func-stack perform a stack trace for function tracer\n" > " (use with caution)\n" > " --max-graph-depth limit function_graph depth\n"
On Thu, 4 Jun 2020 11:51:40 -0400 Steven Rostedt <rostedt@goodmis.org> wrote: > > @@ -53,6 +53,7 @@ static struct usage_help usage_help[] = { > > " --module filter module name\n" > > " --by-comm used with --profile, merge events for related comms\n" > > " --profile enable tracing options needed for report --profile\n" > > + " -G when profiling, set soft and hard irqs as global\n" > > This should be in with the other "simple" options (those with a single > character). The long options "--foo" should always be at the end after all > simple ones. Let me add. I see why you did it this way (because it is right under the --profile), but I think it still should be with the other simple options. I'll update it. Thanks! -- Steve
diff --git a/Documentation/trace-cmd-record.1.txt b/Documentation/trace-cmd-record.1.txt index f5ecad5c..99d1a156 100644 --- a/Documentation/trace-cmd-record.1.txt +++ b/Documentation/trace-cmd-record.1.txt @@ -312,6 +312,10 @@ OPTIONS See trace-cmd-profile(1) for more details and examples. +*-G*:: + Set interrupt (soft and hard) events as global (associated to CPU + instead of tasks). Only works for --profile. + *-H* 'event-hooks':: Add custom event matching to connect any two events together. When not used with *--profile*, it will save the parameter and this will be diff --git a/tracecmd/trace-usage.c b/tracecmd/trace-usage.c index 96647a1e..8036ac7b 100644 --- a/tracecmd/trace-usage.c +++ b/tracecmd/trace-usage.c @@ -53,6 +53,7 @@ static struct usage_help usage_help[] = { " --module filter module name\n" " --by-comm used with --profile, merge events for related comms\n" " --profile enable tracing options needed for report --profile\n" + " -G when profiling, set soft and hard irqs as global\n" " --func-stack perform a stack trace for function tracer\n" " (use with caution)\n" " --max-graph-depth limit function_graph depth\n"
Documented "trace-cmd record -G" option in man page and in the usage output. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> --- Documentation/trace-cmd-record.1.txt | 4 ++++ tracecmd/trace-usage.c | 1 + 2 files changed, 5 insertions(+)