rk3399: Add BOOTENV_SF command
diff mbox series

Message ID 20200608141708.31844-1-jagan@amarulasolutions.com
State New
Headers show
Series
  • rk3399: Add BOOTENV_SF command
Related show

Commit Message

Jagan Teki June 8, 2020, 2:17 p.m. UTC
Add missing BOOTENV_SF command in rk3399 config.

Fix it.

Fixes: f263b860acf8 ("rk3399: Enable SF distro bootcmd")
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Reported-by: Suniel Mahesh <sunil@amarulasolutions.com>
Tested-by: Suniel Mahesh <sunil@amarulasolutions.com>
---
 include/configs/rk3399_common.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Jagan Teki June 25, 2020, 3:02 p.m. UTC | #1
On Mon, Jun 8, 2020 at 7:47 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> Add missing BOOTENV_SF command in rk3399 config.
>
> Fix it.
>
> Fixes: f263b860acf8 ("rk3399: Enable SF distro bootcmd")
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> Reported-by: Suniel Mahesh <sunil@amarulasolutions.com>
> Tested-by: Suniel Mahesh <sunil@amarulasolutions.com>
> ---

Can someone push this fix patch to master?

Jagan.
Tom Rini June 26, 2020, 8:21 p.m. UTC | #2
On Thu, Jun 25, 2020 at 08:32:10PM +0530, Jagan Teki wrote:
> On Mon, Jun 8, 2020 at 7:47 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > Add missing BOOTENV_SF command in rk3399 config.
> >
> > Fix it.
> >
> > Fixes: f263b860acf8 ("rk3399: Enable SF distro bootcmd")
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > Reported-by: Suniel Mahesh <sunil@amarulasolutions.com>
> > Tested-by: Suniel Mahesh <sunil@amarulasolutions.com>
> > ---
> 
> Can someone push this fix patch to master?

Kever, do you want me to pick this up?  Do you have some objection?
FWIW, include/configs/rk3399_common.h should get listed under some
MAINTAINER entry directly.  Thanks!
Kever Yang June 27, 2020, 2:05 p.m. UTC | #3
Hi Tom,

On 2020/6/27 上午4:21, Tom Rini wrote:
> On Thu, Jun 25, 2020 at 08:32:10PM +0530, Jagan Teki wrote:
>> On Mon, Jun 8, 2020 at 7:47 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>>> Add missing BOOTENV_SF command in rk3399 config.
>>>
>>> Fix it.
>>>
>>> Fixes: f263b860acf8 ("rk3399: Enable SF distro bootcmd")
>>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>>> Reported-by: Suniel Mahesh <sunil@amarulasolutions.com>
>>> Tested-by: Suniel Mahesh <sunil@amarulasolutions.com>
>>> ---
>> Can someone push this fix patch to master?
> Kever, do you want me to pick this up?  Do you have some objection?
> FWIW, include/configs/rk3399_common.h should get listed under some
> MAINTAINER entry directly.  Thanks!

I will apply this patch and send to fix RP.

Thanks,

- Kever
Kever Yang June 27, 2020, 2:05 p.m. UTC | #4
On 2020/6/8 下午10:17, Jagan Teki wrote:
> Add missing BOOTENV_SF command in rk3399 config.
>
> Fix it.
>
> Fixes: f263b860acf8 ("rk3399: Enable SF distro bootcmd")
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> Reported-by: Suniel Mahesh <sunil@amarulasolutions.com>
> Tested-by: Suniel Mahesh <sunil@amarulasolutions.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   include/configs/rk3399_common.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
> index f0ae6e67a7..e63ebb14f7 100644
> --- a/include/configs/rk3399_common.h
> +++ b/include/configs/rk3399_common.h
> @@ -67,6 +67,7 @@
>   	"partitions=" PARTS_DEFAULT \
>   	ROCKCHIP_DEVICE_SETTINGS \
>   	BOOTENV \
> +	BOOTENV_SF \
>   	"altbootcmd=" \
>   		"setenv boot_syslinux_conf extlinux/extlinux-rollback.conf;" \
>   		"run distro_bootcmd\0"
Kever Yang June 27, 2020, 2:06 p.m. UTC | #5
On 2020/6/8 下午10:17, Jagan Teki wrote:
> Add missing BOOTENV_SF command in rk3399 config.
>
> Fix it.
>
> Fixes: f263b860acf8 ("rk3399: Enable SF distro bootcmd")
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> Reported-by: Suniel Mahesh <sunil@amarulasolutions.com>
> Tested-by: Suniel Mahesh <sunil@amarulasolutions.com>
Applied to u-boot-rockchip master branch.
> ---
>   include/configs/rk3399_common.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
> index f0ae6e67a7..e63ebb14f7 100644
> --- a/include/configs/rk3399_common.h
> +++ b/include/configs/rk3399_common.h
> @@ -67,6 +67,7 @@
>   	"partitions=" PARTS_DEFAULT \
>   	ROCKCHIP_DEVICE_SETTINGS \
>   	BOOTENV \
> +	BOOTENV_SF \
>   	"altbootcmd=" \
>   		"setenv boot_syslinux_conf extlinux/extlinux-rollback.conf;" \
>   		"run distro_bootcmd\0"

Patch
diff mbox series

diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
index f0ae6e67a7..e63ebb14f7 100644
--- a/include/configs/rk3399_common.h
+++ b/include/configs/rk3399_common.h
@@ -67,6 +67,7 @@ 
 	"partitions=" PARTS_DEFAULT \
 	ROCKCHIP_DEVICE_SETTINGS \
 	BOOTENV \
+	BOOTENV_SF \
 	"altbootcmd=" \
 		"setenv boot_syslinux_conf extlinux/extlinux-rollback.conf;" \
 		"run distro_bootcmd\0"