| Message ID | 20200611064452.12353-9-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/12] blk-mq: merge blk-softirq.c into blk-mq.c | expand |
On Thu, Jun 11, 2020 at 08:44:48AM +0200, Christoph Hellwig wrote: > We don't really care if we get migrated during the I/O completion. > In the worth case we either perform an IPI that wasn't required, or > complete the request on a CPU which we just migrated off. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Daniel Wagner <dwagner@suse.de>
diff --git a/block/blk-mq.c b/block/blk-mq.c index b73b193809097b..45294cd5d875cc 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -685,7 +685,7 @@ void blk_mq_complete_request(struct request *rq) return; } - cpu = get_cpu(); + cpu = raw_smp_processor_id(); if (!test_bit(QUEUE_FLAG_SAME_FORCE, &q->queue_flags)) shared = cpus_share_cache(cpu, ctx->cpu); @@ -697,7 +697,6 @@ void blk_mq_complete_request(struct request *rq) } else { __blk_mq_complete_request(rq); } - put_cpu(); } EXPORT_SYMBOL(blk_mq_complete_request);
We don't really care if we get migrated during the I/O completion. In the worth case we either perform an IPI that wasn't required, or complete the request on a CPU which we just migrated off. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/blk-mq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)