@@ -51,7 +51,6 @@ static char fs_name[PATH_MAX];
static char path_name[PATH_MAX];
static char symlink_target[PATH_MAX];
static int get_snaps = 0;
-static int verbose = 0;
static int restore_metadata = 0;
static int restore_symlinks = 0;
static int ignore_errors = 0;
@@ -386,8 +385,7 @@ static int copy_one_extent(struct btrfs_root *root, int fd,
size_left -= offset;
}
- if (verbose && offset)
- printf("offset is %Lu\n", offset);
+ pr_verbose(offset ? 1 : 0, "offset is %Lu\n", offset);
inbuf = malloc(size_left);
if (!inbuf) {
@@ -820,11 +818,15 @@ static int overwrite_ok(const char * path)
if (overwrite)
return 2;
- if (verbose || !warn)
- printf("Skipping existing file"
- " %s\n", path);
- if (!warn)
- printf("If you wish to overwrite use -o\n");
+ if (!warn) {
+ pr_verbose(MUST_LOG,
+ "Skipping existing file %s\n", path);
+ pr_verbose(MUST_LOG,
+ "If you wish to overwrite use -o\n");
+ } else {
+ pr_verbose(1, "Skipping existing file %s\n", path);
+ }
+
warn = 1;
return 0;
}
@@ -899,8 +901,7 @@ static int copy_symlink(struct btrfs_root *root, struct btrfs_key *key,
}
}
- if (verbose >= 2)
- printf("SYMLINK: '%s' => '%s'\n", path_name, symlink_target);
+ pr_verbose(2, "SYMLINK: '%s' => '%s'\n", path_name, symlink_target);
ret = 0;
if (!restore_metadata)
@@ -977,9 +978,8 @@ static int search_dir(struct btrfs_root *root, struct btrfs_key *key,
leaf = path.nodes[0];
while (!leaf) {
- if (verbose > 1)
- printf("No leaf after search, looking for the next "
- "leaf\n");
+ pr_verbose(2,
+ "No leaf after search, looking for the next leaf\n");
ret = next_leaf(root, &path);
if (ret < 0) {
fprintf(stderr, "Error getting next leaf %d\n",
@@ -987,9 +987,8 @@ static int search_dir(struct btrfs_root *root, struct btrfs_key *key,
goto out;
} else if (ret > 0) {
/* No more leaves to search */
- if (verbose)
- printf("Reached the end of the tree looking "
- "for the directory\n");
+ pr_verbose(1,
+ "Reached the end of the tree looking for the directory\n");
ret = 0;
goto out;
}
@@ -1013,10 +1012,8 @@ static int search_dir(struct btrfs_root *root, struct btrfs_key *key,
goto out;
} else if (ret > 0) {
/* No more leaves to search */
- if (verbose)
- printf("Reached the end of "
- "the tree searching the"
- " directory\n");
+ pr_verbose(1,
+ "Reached the end of the tree searching the directory\n");
ret = 0;
goto out;
}
@@ -1026,14 +1023,12 @@ static int search_dir(struct btrfs_root *root, struct btrfs_key *key,
}
btrfs_item_key_to_cpu(leaf, &found_key, path.slots[0]);
if (found_key.objectid != key->objectid) {
- if (verbose > 1)
- printf("Found objectid=%Lu, key=%Lu\n",
- found_key.objectid, key->objectid);
+ pr_verbose(2, "Found objectid=%Lu, key=%Lu\n",
+ found_key.objectid, key->objectid);
break;
}
if (found_key.type != key->type) {
- if (verbose > 1)
- printf("Found type=%u, want=%u\n",
+ pr_verbose(2, "Found type=%u, want=%u\n",
found_key.type, key->type);
break;
}
@@ -1062,8 +1057,7 @@ static int search_dir(struct btrfs_root *root, struct btrfs_key *key,
if (!overwrite_ok(path_name))
goto next;
- if (verbose)
- printf("Restoring %s\n", path_name);
+ pr_verbose(1, "Restoring %s\n", path_name);
if (dry_run)
goto next;
fd = open(path_name, O_CREAT|O_WRONLY, 0644);
@@ -1135,8 +1129,7 @@ static int search_dir(struct btrfs_root *root, struct btrfs_key *key,
location.objectid = BTRFS_FIRST_FREE_OBJECTID;
}
- if (verbose)
- printf("Restoring %s\n", path_name);
+ pr_verbose(1, "Restoring %s\n", path_name);
errno = 0;
if (dry_run)
@@ -1199,8 +1192,7 @@ next:
}
}
- if (verbose)
- printf("Done searching %s\n", in_dir);
+ pr_verbose(1, "Done searching %s\n", in_dir);
out:
btrfs_release_path(&path);
return ret;
@@ -1410,6 +1402,8 @@ static const char * const cmd_restore_usage[] = {
" you have to use following syntax (possibly quoted):",
" ^/(|home(|/username(|/Desktop(|/.*))))$",
"-c ignore case (--path-regex only)",
+ HELPINFO_INSERT_GLOBALS,
+ HELPINFO_INSERT_VERBOSE,
NULL
};
@@ -1462,7 +1456,7 @@ static int cmd_restore(const struct cmd_struct *cmd, int argc, char **argv)
get_snaps = 1;
break;
case 'v':
- verbose++;
+ bconf_be_verbose();
break;
case 'i':
ignore_errors = 1;
Transpire global --verbose option down to the btrfs restore sub-command. Suggested-by: David Sterba <dsterba@suse.com> Signed-off-by: Anand Jain <anand.jain@oracle.com> --- v3: Use MUST_LOG v2: Use new helper functions and defines HELPINFO_INSERT_GLOBALS, BTRFS_BCONF_UNSET, BTRFS_BCONF_QUIET bconf_be_verbose(), bconf_be_quiet() cmds/restore.c | 58 ++++++++++++++++++++++---------------------------- 1 file changed, 26 insertions(+), 32 deletions(-)