From patchwork Sun Jun 14 17:07:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Leroy X-Patchwork-Id: 11603367 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 00820912 for ; Sun, 14 Jun 2020 17:07:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAD2120747 for ; Sun, 14 Jun 2020 17:07:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726921AbgFNRHP (ORCPT ); Sun, 14 Jun 2020 13:07:15 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:18445 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726905AbgFNRHO (ORCPT ); Sun, 14 Jun 2020 13:07:14 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 49lLVM2GGjzB09bL; Sun, 14 Jun 2020 19:07:07 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id fFXltivinHFx; Sun, 14 Jun 2020 19:07:07 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 49lLVM1QrWzB09b0; Sun, 14 Jun 2020 19:07:07 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id EC3C18B76A; Sun, 14 Jun 2020 19:07:11 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id JN9iOU_Lvrkr; Sun, 14 Jun 2020 19:07:11 +0200 (CEST) Received: from pc16570vm.idsi0.si.c-s.fr (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id B3CF58B75F; Sun, 14 Jun 2020 19:07:11 +0200 (CEST) Received: by pc16570vm.idsi0.si.c-s.fr (Postfix, from userid 0) id 6C40565AF2; Sun, 14 Jun 2020 17:07:11 +0000 (UTC) Message-Id: From: Christophe Leroy Subject: [PATCH] SUNRPC: Add missing asm/cacheflush.h To: Chuck Lever , "J. Bruce Fields" , Trond Myklebust , Anna Schumaker , "David S. Miller" , Jakub Kicinski Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org Date: Sun, 14 Jun 2020 17:07:11 +0000 (UTC) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Even if that's only a warning, not including asm/cacheflush.h leads to svc_flush_bvec() being empty allthough powerpc defines ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE. CC net/sunrpc/svcsock.o net/sunrpc/svcsock.c:227:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined [-Wundef] #if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE ^ Fixes: ca07eda33e01 ("SUNRPC: Refactor svc_recvfrom()") Signed-off-by: Christophe Leroy --- I detected this on linux-next on June 4th and warned Chuck. Seems like it went into mainline anyway. net/sunrpc/svcsock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c index 5c4ec9386f81..d9e99cb09aab 100644 --- a/net/sunrpc/svcsock.c +++ b/net/sunrpc/svcsock.c @@ -45,6 +45,7 @@ #include #include #include +#include #include #include