[V2] ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode
diff mbox series

Message ID 20200615155701.GA3845236@x1
State New
Headers show
Series
  • [V2] ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode
Related show

Commit Message

Drew Fustini June 15, 2020, 3:57 p.m. UTC
Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for
RGMII mode") the networking is broken on the BeagleBone AI which has
the AR8035 PHY for Gigabit Ethernet [0].  The fix is to switch from
phy-mode = "rgmii" to phy-mode = "rgmii-rxid".

Note: Grygorii made a similar DT fix for other AM57xx boards with a
different phy in commit 820f8a870f65 ("ARM: dts: am57xx: fix networking
on boards with ksz9031 phy").

[0] https://git.io/Jf7PX

Fixes: 520557d4854b ("ARM: dts: am5729: beaglebone-ai: adding device tree")
Cc: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Drew Fustini <drew@beagleboard.org>
---
V2:
- fix formatting of commit reference
- add Review-by: from Grygorii

 arch/arm/boot/dts/am5729-beagleboneai.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tony Lindgren June 16, 2020, 4:12 p.m. UTC | #1
* Drew Fustini <drew@beagleboard.org> [200615 08:58]:
> Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for
> RGMII mode") the networking is broken on the BeagleBone AI which has
> the AR8035 PHY for Gigabit Ethernet [0].  The fix is to switch from
> phy-mode = "rgmii" to phy-mode = "rgmii-rxid".
> 
> Note: Grygorii made a similar DT fix for other AM57xx boards with a
> different phy in commit 820f8a870f65 ("ARM: dts: am57xx: fix networking
> on boards with ksz9031 phy").
> 
> [0] https://git.io/Jf7PX
> 
> Fixes: 520557d4854b ("ARM: dts: am5729: beaglebone-ai: adding device tree")
> Cc: Vinod Koul <vkoul@kernel.org>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> V2:
> - fix formatting of commit reference
> - add Review-by: from Grygorii

Thanks applying into fixes.

Regards,

Tony

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/am5729-beagleboneai.dts b/arch/arm/boot/dts/am5729-beagleboneai.dts
index 9877d7709d41..4c51c6b05e64 100644
--- a/arch/arm/boot/dts/am5729-beagleboneai.dts
+++ b/arch/arm/boot/dts/am5729-beagleboneai.dts
@@ -505,7 +505,7 @@  &mac {
 
 &cpsw_emac0 {
 	phy-handle = <&phy0>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-rxid";
 };
 
 &ocp {