[v2] drm/mediatek: remove unnecessary conversion to bool
diff mbox series

Message ID 20200616065102.15756-1-bernard@vivo.com
State New
Headers show
Series
  • [v2] drm/mediatek: remove unnecessary conversion to bool
Related show

Commit Message

Bernard Zhao June 16, 2020, 6:51 a.m. UTC
In function mtk_dsi_clk_hs_state, remove unnecessary conversion
to bool return, this change is to make the code a bit readable.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
Changes since V1:
*optimize to make the code a bit more clear.

Link for V1:
*https://lore.kernel.org/patchwork/patch/1255327/
---
 drivers/gpu/drm/mediatek/mtk_dsi.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Chun-Kuang Hu June 28, 2020, 2:19 p.m. UTC | #1
Hi, Bernard:

Bernard Zhao <bernard@vivo.com> 於 2020年6月16日 週二 下午2:51寫道:
>
> In function mtk_dsi_clk_hs_state, remove unnecessary conversion
> to bool return, this change is to make the code a bit readable.

Applied to mediatek-drm-fixes [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes

Regards,
Chun-Kuang.

>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
> Changes since V1:
> *optimize to make the code a bit more clear.
>
> Link for V1:
> *https://lore.kernel.org/patchwork/patch/1255327/
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 4491e64b3f06..840cc9b9efc8 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -316,10 +316,7 @@ static void mtk_dsi_lane0_ulp_mode_leave(struct mtk_dsi *dsi)
>
>  static bool mtk_dsi_clk_hs_state(struct mtk_dsi *dsi)
>  {
> -       u32 tmp_reg1;
> -
> -       tmp_reg1 = readl(dsi->regs + DSI_PHY_LCCON);
> -       return ((tmp_reg1 & LC_HS_TX_EN) == 1);
> +       return (readl(dsi->regs + DSI_PHY_LCCON) & LC_HS_TX_EN);
>  }
>
>  static void mtk_dsi_clk_hs_mode(struct mtk_dsi *dsi, bool enter)
> --
> 2.17.1
>

Patch
diff mbox series

diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 4491e64b3f06..840cc9b9efc8 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -316,10 +316,7 @@  static void mtk_dsi_lane0_ulp_mode_leave(struct mtk_dsi *dsi)
 
 static bool mtk_dsi_clk_hs_state(struct mtk_dsi *dsi)
 {
-	u32 tmp_reg1;
-
-	tmp_reg1 = readl(dsi->regs + DSI_PHY_LCCON);
-	return ((tmp_reg1 & LC_HS_TX_EN) == 1);
+	return (readl(dsi->regs + DSI_PHY_LCCON) & LC_HS_TX_EN);
 }
 
 static void mtk_dsi_clk_hs_mode(struct mtk_dsi *dsi, bool enter)