[2/4] cpuidle: big.LITTLE: enable driver only on Peach-Pit/Pi Chromebooks
diff mbox series

Message ID 20200616081230.31198-3-m.szyprowski@samsung.com
State Not Applicable
Headers show
Series
  • Restore big.LITTLE cpuidle driver for Exynos
Related show

Commit Message

Marek Szyprowski June 16, 2020, 8:12 a.m. UTC
This driver always worked properly only on the Exynos 5420/5800 based
Chromebooks (Peach-Pit/Pi), so change the required compatible string to
the 'google,peach', to avoid enabling it on the other Exynos 542x/5800
boards, which hangs in such case. The main difference between Peach-Pit/Pi
and other Exynos 542x/5800 boards is the firmware - Peach platform doesn't
use secure firmware at all.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 drivers/cpuidle/cpuidle-big_little.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Krzysztof Kozlowski June 22, 2020, 5:19 p.m. UTC | #1
On Tue, Jun 16, 2020 at 10:12:28AM +0200, Marek Szyprowski wrote:
> This driver always worked properly only on the Exynos 5420/5800 based
> Chromebooks (Peach-Pit/Pi), so change the required compatible string to
> the 'google,peach', to avoid enabling it on the other Exynos 542x/5800
> boards, which hangs in such case. The main difference between Peach-Pit/Pi
> and other Exynos 542x/5800 boards is the firmware - Peach platform doesn't
> use secure firmware at all.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  drivers/cpuidle/cpuidle-big_little.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Bartlomiej Zolnierkiewicz June 24, 2020, 10:05 a.m. UTC | #2
On 6/16/20 10:12 AM, Marek Szyprowski wrote:
> This driver always worked properly only on the Exynos 5420/5800 based
> Chromebooks (Peach-Pit/Pi), so change the required compatible string to
> the 'google,peach', to avoid enabling it on the other Exynos 542x/5800
> boards, which hangs in such case. The main difference between Peach-Pit/Pi
> and other Exynos 542x/5800 boards is the firmware - Peach platform doesn't
> use secure firmware at all.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/cpuidle/cpuidle-big_little.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
> index 7f8ddc04342d..abe51185f243 100644
> --- a/drivers/cpuidle/cpuidle-big_little.c
> +++ b/drivers/cpuidle/cpuidle-big_little.c
> @@ -155,8 +155,7 @@ static int __init bl_idle_driver_init(struct cpuidle_driver *drv, int part_id)
>  
>  static const struct of_device_id compatible_machine_match[] = {
>  	{ .compatible = "arm,vexpress,v2p-ca15_a7" },
> -	{ .compatible = "samsung,exynos5420" },
> -	{ .compatible = "samsung,exynos5800" },
> +	{ .compatible = "google,peach" },
>  	{},
>  };
>  
>

Patch
diff mbox series

diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
index 7f8ddc04342d..abe51185f243 100644
--- a/drivers/cpuidle/cpuidle-big_little.c
+++ b/drivers/cpuidle/cpuidle-big_little.c
@@ -155,8 +155,7 @@  static int __init bl_idle_driver_init(struct cpuidle_driver *drv, int part_id)
 
 static const struct of_device_id compatible_machine_match[] = {
 	{ .compatible = "arm,vexpress,v2p-ca15_a7" },
-	{ .compatible = "samsung,exynos5420" },
-	{ .compatible = "samsung,exynos5800" },
+	{ .compatible = "google,peach" },
 	{},
 };