| Message ID | 1341493572-29735-8-git-send-email-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jul 5, 2012 at 3:06 PM, Lee Jones <lee.jones@linaro.org> wrote: > Before we can use any domain allocated IRQ, we need to first create a > map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq). > We do this with a helper function provided by the AB8500 IRQ domain > controller called ab8500_irq_get_virq(). We need to do this for both > IRQs which the Power-On-Key driver uses; one for button press, the other > for button depress. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> Acked-by: Linus Walleij <linus.walleij@linaro.org> Lee I think the in-kernel charging drivers in drivers/power/ab8500_* are also using the IRQs, have you checked that these also do the right thing? (I realize they may be hard to test, but atleast make an effort). Please coordinate with Rajanikanth who is working on DT:ing these drivers. Yours, Linus Walleij
diff --git a/drivers/input/misc/ab8500-ponkey.c b/drivers/input/misc/ab8500-ponkey.c index 5ceb23e..ae4b683 100644 --- a/drivers/input/misc/ab8500-ponkey.c +++ b/drivers/input/misc/ab8500-ponkey.c @@ -82,6 +82,7 @@ static int __devinit ab8500_ponkey_probe(struct platform_device *pdev) input_set_capability(input, EV_KEY, KEY_POWER); + ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, ponkey->irq_dbf); error = request_any_context_irq(ponkey->irq_dbf, ab8500_ponkey_handler, 0, "ab8500-ponkey-dbf", ponkey); if (error < 0) { @@ -90,6 +91,7 @@ static int __devinit ab8500_ponkey_probe(struct platform_device *pdev) goto err_free_mem; } + ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, ponkey->irq_dbr); error = request_any_context_irq(ponkey->irq_dbr, ab8500_ponkey_handler, 0, "ab8500-ponkey-dbr", ponkey); if (error < 0) {
Before we can use any domain allocated IRQ, we need to first create a map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq). We do this with a helper function provided by the AB8500 IRQ domain controller called ab8500_irq_get_virq(). We need to do this for both IRQs which the Power-On-Key driver uses; one for button press, the other for button depress. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/input/misc/ab8500-ponkey.c | 2 ++ 1 file changed, 2 insertions(+)