vfs/xattr: strengthen error check to avoid unexpected result
diff mbox series

Message ID 20200617010827.16048-1-cgxu519@mykernel.net
State New
Headers show
Series
  • vfs/xattr: strengthen error check to avoid unexpected result
Related show

Commit Message

Chengguang Xu June 17, 2020, 1:08 a.m. UTC
The variable error is ssize_t, which is signed and will
cast to unsigned when comapre with variable size, so add
a check to avoid unexpected result in case of negative
value of error.

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
 fs/xattr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch
diff mbox series

diff --git a/fs/xattr.c b/fs/xattr.c
index e13265e65871..9d0f12682c86 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -356,7 +356,7 @@  vfs_listxattr(struct dentry *dentry, char *list, size_t size)
 		error = inode->i_op->listxattr(dentry, list, size);
 	} else {
 		error = security_inode_listsecurity(inode, list, size);
-		if (size && error > size)
+		if (error >= 0 && size && error > size)
 			error = -ERANGE;
 	}
 	return error;