[PULL,00/43] Block layer patches
mbox

Message ID 20200617144909.192176-1-kwolf@redhat.com
State New
Headers show

Pull-request

git://repo.or.cz/qemu/kevin.git tags/for-upstream

Message

Kevin Wolf June 17, 2020, 2:48 p.m. UTC
The following changes since commit 5c24bce3056ff209a1ecc50ff4b7e65b85ad8e74:

  Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-and-plugin-160620-2' into staging (2020-06-16 14:57:15 +0100)

are available in the Git repository at:

  git://repo.or.cz/qemu/kevin.git tags/for-upstream

for you to fetch changes up to 3419ec713f04c323b030e0763459435335b25476:

  iotests: Add copyright line in qcow2.py (2020-06-17 16:21:21 +0200)

----------------------------------------------------------------
Block layer patches:

- enhance handling of size-related BlockConf properties
- nvme: small fixes, refactoring and cleanups
- virtio-blk: On restart, process queued requests in the proper context
- icount: make dma reads deterministic
- iotests: Some fixes for rarely run cases
- .gitignore: Ignore storage-daemon files
- Minor code cleanups

----------------------------------------------------------------
Eric Blake (3):
      block: Refactor subdirectory recursion during make
      qcow2: Tweak comments on qcow2_get_persistent_dirty_bitmap_size
      iotests: Add copyright line in qcow2.py

Klaus Jensen (21):
      hw/block/nvme: fix pci doorbell size calculation
      hw/block/nvme: rename trace events to pci_nvme
      hw/block/nvme: remove superfluous breaks
      hw/block/nvme: move device parameters to separate struct
      hw/block/nvme: use constants in identify
      hw/block/nvme: refactor nvme_addr_read
      hw/block/nvme: fix pin-based interrupt behavior
      hw/block/nvme: add max_ioqpairs device parameter
      hw/block/nvme: remove redundant cmbloc/cmbsz members
      hw/block/nvme: factor out property/constraint checks
      hw/block/nvme: factor out device state setup
      hw/block/nvme: factor out block backend setup
      hw/block/nvme: add namespace helpers
      hw/block/nvme: factor out namespace setup
      hw/block/nvme: factor out pci setup
      hw/block/nvme: factor out cmb setup
      hw/block/nvme: factor out pmr setup
      hw/block/nvme: do cmb/pmr init as part of pci init
      hw/block/nvme: factor out controller identify setup
      hw/block/nvme: add msix_qsize parameter
      hw/block/nvme: verify msix_init_exclusive_bar() return value

Max Reitz (5):
      iotests.py: Add skip_for_formats() decorator
      iotests/041: Skip test_small_target for qed
      iotests/292: data_file is unsupported
      iotests/229: data_file is unsupported
      iotests/{190,291}: compat=0.10 is unsupported

Pavel Dovgaluk (1):
      icount: make dma reads deterministic

Philippe Mathieu-Daudé (2):
      hw/ide: Make IDEDMAOps handlers take a const IDEDMA pointer
      hw/block/nvme: Verify msix_vector_use() returned value

Roman Bolshakov (1):
      .gitignore: Ignore storage-daemon files

Roman Kagan (8):
      virtio-blk: store opt_io_size with correct size
      block: consolidate blocksize properties consistency checks
      qdev-properties: blocksize: use same limits in code and description
      qdev-properties: add size32 property type
      qdev-properties: make blocksize accept size suffixes
      block: make BlockConf size props 32bit and accept size suffixes
      qdev-properties: add getter for size32 and blocksize
      block: lift blocksize property limit to 2 MiB

Sergio Lopez (2):
      virtio-blk: Refactor the code that processes queued requests
      virtio-blk: On restart, process queued requests in the proper context

 hw/block/nvme.h                    |  34 ++-
 include/block/nvme.h               |   8 +
 include/hw/block/block.h           |  14 +-
 include/hw/ide/internal.h          |  12 +-
 include/hw/qdev-properties.h       |   5 +-
 include/hw/virtio/virtio-blk.h     |   1 +
 block/qcow2-bitmap.c               |   9 +-
 dma-helpers.c                      |  22 ++
 hw/block/block.c                   |  40 ++-
 hw/block/dataplane/virtio-blk.c    |   8 +
 hw/block/fdc.c                     |   5 +-
 hw/block/nvme.c                    | 574 +++++++++++++++++++++----------------
 hw/block/swim.c                    |   5 +-
 hw/block/virtio-blk.c              |  39 +--
 hw/block/xen-block.c               |   6 +-
 hw/core/qdev-properties.c          |  85 +++++-
 hw/ide/ahci.c                      |  18 +-
 hw/ide/core.c                      |   6 +-
 hw/ide/macio.c                     |   6 +-
 hw/ide/pci.c                       |  12 +-
 hw/ide/qdev.c                      |   5 +-
 hw/scsi/scsi-disk.c                |  12 +-
 hw/usb/dev-storage.c               |   5 +-
 tests/qemu-iotests/iotests.py      |  16 ++
 tests/qemu-iotests/qcow2.py        |   2 +
 tests/qemu-iotests/qcow2_format.py |   1 +
 .gitignore                         |  17 +-
 Makefile.objs                      |   2 +-
 block/Makefile.objs                |   1 +
 hw/block/trace-events              | 180 ++++++------
 tests/qemu-iotests/041             |   2 +
 tests/qemu-iotests/118             |   7 +-
 tests/qemu-iotests/172.out         | 532 +++++++++++++++++-----------------
 tests/qemu-iotests/190             |   2 +
 tests/qemu-iotests/229             |   3 +
 tests/qemu-iotests/291             |   2 +
 tests/qemu-iotests/292             |   5 +
 37 files changed, 1005 insertions(+), 698 deletions(-)

Comments

no-reply@patchew.org June 17, 2020, 3:48 p.m. UTC | #1
Patchew URL: https://patchew.org/QEMU/20200617144909.192176-1-kwolf@redhat.com/



Hi,

This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===

  LINK    tests/qemu-iotests/socket_scm_helper
  GEN     docs/interop/qemu-qmp-ref.html
  GEN     docs/interop/qemu-qmp-ref.txt
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
  GEN     docs/interop/qemu-qmp-ref.7
  CC      qga/commands.o
  CC      qga/guest-agent-command-state.o
---
  CC      qemu-img.o
  AS      pc-bios/optionrom/pvh.o
  CC      pc-bios/optionrom/pvh_main.o
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
  BUILD   pc-bios/optionrom/multiboot.img
  BUILD   pc-bios/optionrom/linuxboot.img
  BUILD   pc-bios/optionrom/kvmvapic.img
---
  BUILD   pc-bios/optionrom/pvh.raw
  SIGN    pc-bios/optionrom/pvh.bin
  LINK    fsdev/virtfs-proxy-helper
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
  LINK    scsi/qemu-pr-helper
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
  AR      libvhost-user.a
  LINK    qemu-bridge-helper
  GEN     docs/interop/qemu-ga-ref.txt
  GEN     docs/interop/qemu-ga-ref.7
  GEN     docs/interop/qemu-ga-ref.html
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
  LINK    qemu-ga
  LINK    qemu-keymap
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
  LINK    ivshmem-client
  LINK    ivshmem-server
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
  LINK    qemu-nbd
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
  LINK    qemu-storage-daemon
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
  LINK    qemu-img
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
  LINK    virtiofsd
  LINK    vhost-user-input
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
/usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o)
  GEN     x86_64-softmmu/config-devices.h
  GEN     x86_64-softmmu/hmp-commands.h
  GEN     x86_64-softmmu/hmp-commands-info.h
---
  CC      x86_64-softmmu/hw/display/virtio-gpu-3d.o
  CC      x86_64-softmmu/hw/display/vhost-user-gpu.o
  CC      x86_64-softmmu/hw/display/virtio-gpu-pci.o
/tmp/qemu-test/src/fpu/softfloat.c:3365:13: error: bitwise negation of a boolean expression; did you mean logical negation? [-Werror,-Wbool-operation]
    absZ &= ~ ( ( ( roundBits ^ 0x40 ) == 0 ) & roundNearestEven );
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            !
/tmp/qemu-test/src/fpu/softfloat.c:3423:18: error: bitwise negation of a boolean expression; did you mean logical negation? [-Werror,-Wbool-operation]
        absZ0 &= ~ ( ( (uint64_t) ( absZ1<<1 ) == 0 ) & roundNearestEven );
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                 !
/tmp/qemu-test/src/fpu/softfloat.c:3483:18: error: bitwise negation of a boolean expression; did you mean logical negation? [-Werror,-Wbool-operation]
        absZ0 &= ~(((uint64_t)(absZ1<<1) == 0) & roundNearestEven);
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                 !
/tmp/qemu-test/src/fpu/softfloat.c:3606:13: error: bitwise negation of a boolean expression; did you mean logical negation? [-Werror,-Wbool-operation]
    zSig &= ~ ( ( ( roundBits ^ 0x40 ) == 0 ) & roundNearestEven );
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            !
/tmp/qemu-test/src/fpu/softfloat.c:3760:13: error: bitwise negation of a boolean expression; did you mean logical negation? [-Werror,-Wbool-operation]
    zSig &= ~ ( ( ( roundBits ^ 0x200 ) == 0 ) & roundNearestEven );
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            !
/tmp/qemu-test/src/fpu/softfloat.c:3987:21: error: bitwise negation of a boolean expression; did you mean logical negation? [-Werror,-Wbool-operation]
                    ~ ( ( (uint64_t) ( zSig1<<1 ) == 0 ) & roundNearestEven );
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                    !
/tmp/qemu-test/src/fpu/softfloat.c:4003:22: error: bitwise negation of a boolean expression; did you mean logical negation? [-Werror,-Wbool-operation]
            zSig0 &= ~ ( ( (uint64_t) ( zSig1<<1 ) == 0 ) & roundNearestEven );
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                     !
/tmp/qemu-test/src/fpu/softfloat.c:4273:18: error: bitwise negation of a boolean expression; did you mean logical negation? [-Werror,-Wbool-operation]
        zSig1 &= ~ ( ( zSig2 + zSig2 == 0 ) & roundNearestEven );
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                 !
8 errors generated.
make[1]: *** [/tmp/qemu-test/src/rules.mak:69: fpu/softfloat.o] Error 1
make[1]: *** Waiting for unfinished jobs....
/tmp/qemu-test/src/migration/ram.c:919:45: error: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709551615 to 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion]
            xbzrle_counters.encoding_rate = UINT64_MAX;
                                          ~ ^~~~~~~~~~
/usr/include/stdint.h:130:23: note: expanded from macro 'UINT64_MAX'
---
18446744073709551615UL
^~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [/tmp/qemu-test/src/rules.mak:69: migration/ram.o] Error 1
make: *** [Makefile:527: x86_64-softmmu/all] Error 2
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 669, in <module>
    sys.exit(main())
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=ecde33fcb447459dba264151196412fa', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=x86_64-softmmu', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-3f4xzswk/src/docker-src.2020-06-17-11.44.22.15375:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-debug']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=ecde33fcb447459dba264151196412fa
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-3f4xzswk/src'
make: *** [docker-run-test-debug@fedora] Error 2

real    4m16.507s
user    0m7.992s


The full log is available at
http://patchew.org/logs/20200617144909.192176-1-kwolf@redhat.com/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell June 18, 2020, 2:30 p.m. UTC | #2
On Wed, 17 Jun 2020 at 15:49, Kevin Wolf <kwolf@redhat.com> wrote:
>
> The following changes since commit 5c24bce3056ff209a1ecc50ff4b7e65b85ad8e74:
>
>   Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-and-plugin-160620-2' into staging (2020-06-16 14:57:15 +0100)
>
> are available in the Git repository at:
>
>   git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to 3419ec713f04c323b030e0763459435335b25476:
>
>   iotests: Add copyright line in qcow2.py (2020-06-17 16:21:21 +0200)
>
> ----------------------------------------------------------------
> Block layer patches:
>
> - enhance handling of size-related BlockConf properties
> - nvme: small fixes, refactoring and cleanups
> - virtio-blk: On restart, process queued requests in the proper context
> - icount: make dma reads deterministic
> - iotests: Some fixes for rarely run cases
> - .gitignore: Ignore storage-daemon files
> - Minor code cleanups
>
> ----------------------------------------------------------------


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1
for any user-visible changes.

-- PMM
Klaus Jensen June 25, 2020, 8:39 a.m. UTC | #3
On Jun 18 15:30, Peter Maydell wrote:
> On Wed, 17 Jun 2020 at 15:49, Kevin Wolf <kwolf@redhat.com> wrote:
> >
> > The following changes since commit 5c24bce3056ff209a1ecc50ff4b7e65b85ad8e74:
> >
> >   Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-and-plugin-160620-2' into staging (2020-06-16 14:57:15 +0100)
> >
> > are available in the Git repository at:
> >
> >   git://repo.or.cz/qemu/kevin.git tags/for-upstream
> >
> > for you to fetch changes up to 3419ec713f04c323b030e0763459435335b25476:
> >
> >   iotests: Add copyright line in qcow2.py (2020-06-17 16:21:21 +0200)
> >
> > ----------------------------------------------------------------
> > Block layer patches:
> >
> > - enhance handling of size-related BlockConf properties
> > - nvme: small fixes, refactoring and cleanups
> > - virtio-blk: On restart, process queued requests in the proper context
> > - icount: make dma reads deterministic
> > - iotests: Some fixes for rarely run cases
> > - .gitignore: Ignore storage-daemon files
> > - Minor code cleanups
> >
> > ----------------------------------------------------------------
> 
> 
> Applied, thanks.
> 
> Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1
> for any user-visible changes.
> 

Kevin, can you add soemthing like the following to the changelog under
"Block devices"?

Emulated NVMe device (hw/block/nvme):

  * Add the max_ioqpairs device parameter. The parameter specifies the
    maximum number of supported I/O queue pairs and should be used
    instead of the num_queues parameter. num_queues is not formally
    deprecated, but the device will issue a warning if used. If neither
    num_queues or max_ioqpairs are specified, device behavior is
    unchanged from the previous default.

  * Add the msix_qsize parameter. The parameter specifies the maximum
    number of msix interrupt vectors supported by the device. If not
    specified, device behavior is unchanged from the previous default.
Kevin Wolf June 25, 2020, 10:39 a.m. UTC | #4
Am 25.06.2020 um 10:39 hat Klaus Jensen geschrieben:
> On Jun 18 15:30, Peter Maydell wrote:
> > On Wed, 17 Jun 2020 at 15:49, Kevin Wolf <kwolf@redhat.com> wrote:
> > >
> > > The following changes since commit 5c24bce3056ff209a1ecc50ff4b7e65b85ad8e74:
> > >
> > >   Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-and-plugin-160620-2' into staging (2020-06-16 14:57:15 +0100)
> > >
> > > are available in the Git repository at:
> > >
> > >   git://repo.or.cz/qemu/kevin.git tags/for-upstream
> > >
> > > for you to fetch changes up to 3419ec713f04c323b030e0763459435335b25476:
> > >
> > >   iotests: Add copyright line in qcow2.py (2020-06-17 16:21:21 +0200)
> > >
> > > ----------------------------------------------------------------
> > > Block layer patches:
> > >
> > > - enhance handling of size-related BlockConf properties
> > > - nvme: small fixes, refactoring and cleanups
> > > - virtio-blk: On restart, process queued requests in the proper context
> > > - icount: make dma reads deterministic
> > > - iotests: Some fixes for rarely run cases
> > > - .gitignore: Ignore storage-daemon files
> > > - Minor code cleanups
> > >
> > > ----------------------------------------------------------------
> > 
> > 
> > Applied, thanks.
> > 
> > Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1
> > for any user-visible changes.
> > 
> 
> Kevin, can you add soemthing like the following to the changelog under
> "Block devices"?
> 
> Emulated NVMe device (hw/block/nvme):
> 
>   * Add the max_ioqpairs device parameter. The parameter specifies the
>     maximum number of supported I/O queue pairs and should be used
>     instead of the num_queues parameter. num_queues is not formally
>     deprecated, but the device will issue a warning if used. If neither
>     num_queues or max_ioqpairs are specified, device behavior is
>     unchanged from the previous default.
> 
>   * Add the msix_qsize parameter. The parameter specifies the maximum
>     number of msix interrupt vectors supported by the device. If not
>     specified, device behavior is unchanged from the previous default.

Sure, I've added this.

If you want to have a wiki account so that you can edit the page
yourself in the future, let me (or anyone else with a wiki account) know
your preferred user name and we can create an account for you. Access is
not supposed to be a privileged thing, we just require manual
registration through an existing account to avoid spam.

Kevin