[i-g-t,06/10] gem_wsim: Support scaling workload batch durations
diff mbox series

Message ID 20200617160120.16555-7-tvrtko.ursulin@linux.intel.com
State New
Headers show
Series
  • gem_wsim improvements
Related show

Commit Message

Tvrtko Ursulin June 17, 2020, 4:01 p.m. UTC
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

-f <float> on the command line can be used to scale batch buffer durations
in all parsed workloads.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 benchmarks/gem_wsim.c | 27 ++++++++++++++++++++-------
 1 file changed, 20 insertions(+), 7 deletions(-)

Comments

Chris Wilson June 17, 2020, 4:22 p.m. UTC | #1
Quoting Tvrtko Ursulin (2020-06-17 17:01:16)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> -f <float> on the command line can be used to scale batch buffer durations
> in all parsed workloads.

But not the period?
-Chris
Tvrtko Ursulin June 18, 2020, 8:01 a.m. UTC | #2
On 17/06/2020 17:22, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2020-06-17 17:01:16)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> -f <float> on the command line can be used to scale batch buffer durations
>> in all parsed workloads.
> 
> But not the period?

I had it scale both at some point but then it ended up more useful to 
only do batches. So I could stuff more clients in before saturation. I 
suppose that's an argument to have both independently controlled.

Regards,

Tvrtko
Chris Wilson June 18, 2020, 8:07 a.m. UTC | #3
Quoting Tvrtko Ursulin (2020-06-18 09:01:10)
> 
> On 17/06/2020 17:22, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2020-06-17 17:01:16)
> >> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>
> >> -f <float> on the command line can be used to scale batch buffer durations
> >> in all parsed workloads.
> > 
> > But not the period?
> 
> I had it scale both at some point but then it ended up more useful to 
> only do batches. So I could stuff more clients in before saturation. I 
> suppose that's an argument to have both independently controlled.

I was moreover trying to work out why one would want to. I was guessing
shrink the duration and add more clients, and there you would the
independent control, but if you just shrank the duration for a fixed
number of clients, you would also want to shrink the period.
-Chris

Patch
diff mbox series

diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
index c1405596c46a..025385a144b8 100644
--- a/benchmarks/gem_wsim.c
+++ b/benchmarks/gem_wsim.c
@@ -41,6 +41,7 @@ 
 #include <assert.h>
 #include <limits.h>
 #include <pthread.h>
+#include <math.h>
 
 #include "intel_chipset.h"
 #include "intel_reg.h"
@@ -853,6 +854,11 @@  static uint64_t engine_list_mask(const char *_str)
 
 static void allocate_working_set(struct workload *wrk, struct working_set *set);
 
+static long __duration(long dur, double scale)
+{
+	return round(scale * dur);
+}
+
 #define int_field(_STEP_, _FIELD_, _COND_, _ERR_) \
 	if ((field = strtok_r(fstart, ".", &fctx))) { \
 		tmp = atoi(field); \
@@ -863,7 +869,8 @@  static void allocate_working_set(struct workload *wrk, struct working_set *set);
 	} \
 
 static struct workload *
-parse_workload(struct w_arg *arg, unsigned int flags, struct workload *app_w)
+parse_workload(struct w_arg *arg, unsigned int flags, double scale_dur,
+	       struct workload *app_w)
 {
 	struct workload *wrk;
 	unsigned int nr_steps = 0;
@@ -1129,7 +1136,7 @@  parse_workload(struct w_arg *arg, unsigned int flags, struct workload *app_w)
 					  tmpl == LONG_MAX,
 					  "Invalid duration at step %u!\n",
 					  nr_steps);
-				step.duration.min = tmpl;
+				step.duration.min = __duration(tmpl, scale_dur);
 
 				if (sep && *sep == '-') {
 					tmpl = strtol(sep + 1, NULL, 10);
@@ -1139,7 +1146,8 @@  parse_workload(struct w_arg *arg, unsigned int flags, struct workload *app_w)
 						tmpl == LONG_MAX,
 						"Invalid duration range at step %u!\n",
 						nr_steps);
-					step.duration.max = tmpl;
+					step.duration.max = __duration(tmpl,
+								       scale_dur);
 				} else {
 					step.duration.max = step.duration.min;
 				}
@@ -2494,7 +2502,8 @@  static void print_help(void)
 "                    command line. Subsequent -s switches it off.\n"
 "  -S                Synchronize the sequence of random batch durations between\n"
 "                    clients.\n"
-"  -d                Sync between data dependencies in userspace."
+"  -d                Sync between data dependencies in userspace.\n"
+"  -f <scale>        Scale factor for batch durations."
 	);
 }
 
@@ -2556,6 +2565,7 @@  int main(int argc, char **argv)
 	struct w_arg *w_args = NULL;
 	unsigned int tolerance_pct = 1;
 	int exitcode = EXIT_FAILURE;
+	double scale_arg = 1.0f;
 	int prio = 0;
 	double t;
 	int i, c;
@@ -2576,7 +2586,7 @@  int main(int argc, char **argv)
 	master_prng = time(NULL);
 
 	while ((c = getopt(argc, argv,
-			   "ThqvsSdc:n:r:w:W:a:t:p:I:")) != -1) {
+			   "ThqvsSdc:n:r:w:W:a:t:p:I:f:")) != -1) {
 		switch (c) {
 		case 'W':
 			if (master_workload >= 0) {
@@ -2687,6 +2697,9 @@  int main(int argc, char **argv)
 		case 'I':
 			master_prng = strtol(optarg, NULL, 0);
 			break;
+		case 'f':
+			scale_arg = atof(optarg);
+			break;
 		case 'h':
 			print_help();
 			goto out;
@@ -2744,7 +2757,7 @@  int main(int argc, char **argv)
 
 	if (append_workload_arg) {
 		struct w_arg arg = { NULL, append_workload_arg, 0 };
-		app_w = parse_workload(&arg, flags, NULL);
+		app_w = parse_workload(&arg, flags, scale_arg, NULL);
 		if (!app_w) {
 			wsim_err("Failed to parse append workload!\n");
 			goto err;
@@ -2762,7 +2775,7 @@  int main(int argc, char **argv)
 			goto err;
 		}
 
-		wrk[i] = parse_workload(&w_args[i], flags, app_w);
+		wrk[i] = parse_workload(&w_args[i], flags, scale_arg, app_w);
 		if (!wrk[i]) {
 			wsim_err("Failed to parse workload %u!\n", i);
 			goto err;