From patchwork Thu Jun 18 15:39:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 11612813 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7F2BF175D for ; Thu, 18 Jun 2020 16:08:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D5A920776 for ; Thu, 18 Jun 2020 16:08:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fD58X82K"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="CLJW58wU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D5A920776 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/tOdEsqh4vWIIerts1PpFET40Er2KnoB0xRBfaxv0g4=; b=fD58X82K5mg8SN TkQ7S6WuKAb1732vXyg4XSxJRp1RM/wImo5Fi/b98p4ngS8H/2gH1zIEu81JvBtEfFyLCg4NzaqF1 uvI12kFRJf/sYMmNC69uXOPF/urKHH0g1REj96IcHE+7LB6mShb5oBiunyHXnJDCvvJxPFHKaxiR1 YNPzZvgOisI2t4XPdGoNCKoflFT0X/L3OID5i5PX6H/KCviqwwRk7NI/5Ia8ZmjAeZXpqcjA1EPSO +DLDgEGmkPzczeb8F0bAYGqH8TnUQFki88EQ0LzLHrfFWSQHfPyy0BH3+sJPx+eU2ZkUMiW+n0jPF Hjo8l6N454kXbP6ogA3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlx5D-0000IP-2y; Thu, 18 Jun 2020 16:08:07 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlx59-0000Gk-Qq for linux-rockchip@lists.infradead.org; Thu, 18 Jun 2020 16:08:05 +0000 Received: by mail-pl1-x642.google.com with SMTP id v24so2615391plo.6 for ; Thu, 18 Jun 2020 09:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8sFgYtAh2b0Wohv3uaF5Qyt69kdsVZxcLGheuYLU8jY=; b=CLJW58wUdQ9cX2x6//WRzMUQKw87BP8bCFAC+UtrDcusYVavDEfW6ZAgZgVbyOv4cG po20i0OF0v5KMxOwwymCEx8zaOonmui7PkDy5D81vKyr3m4Vo3G9/WVOIUm6iaDNT6Ve 0DxVCQgIZlV3IKvgzymeinGjrMuwPmcCbSWPw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8sFgYtAh2b0Wohv3uaF5Qyt69kdsVZxcLGheuYLU8jY=; b=JP2CzyU2VupW5wFj5vBxlosqZsUh6ZWWFY3l+qR9/JvAUwYqlZM+hjigW2po8oxbR1 OEB0BaqaPBVgdMOq55kfzPY82yDGaxRyCTW2WeHdByanz23r/FR4bLodP8F8JGQQW6eJ UyW1evKpqw1PtWeCD2dVD3gRraO33xV8h2ZZd6wvML0xszGqM/X75rsxi/b28OENc8Ri /w3ht1RbBv9klfs1SjnaiWfWvnke+KJM9N7l6blBRYZoqpcQ7i0A2nVlTQqx3F09dapu QkrQklXVkbPn84tEevqL1J88SHOG15PWd8joCpWCmEVgcS5W3MRmq3d3ScB2kM0RXvnn 9cUg== X-Gm-Message-State: AOAM5307YjFxR5XJANUT0F/AOMOD5wqjSA2rqpcGOAxb79zoIG/Ox41L yvoOPqsRWql7tD98j3OSWjD/NQ== X-Google-Smtp-Source: ABdhPJyNaOqtpgacUTBxXtuk7d6u0lPY4DFww4TLwtCM1+qPYj/YE5W4CX/vrIc+/w+qayACut5lCA== X-Received: by 2002:a17:902:ea8a:: with SMTP id x10mr4325689plb.330.1592496483193; Thu, 18 Jun 2020 09:08:03 -0700 (PDT) Received: from localhost.localdomain ([2405:201:c809:c7d5:b0c7:f192:869b:df87]) by smtp.gmail.com with ESMTPSA id u4sm3264943pfl.102.2020.06.18.09.07.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 09:08:02 -0700 (PDT) From: Jagan Teki To: Kever Yang , Philipp Tomsich , Simon Glass Subject: [PATCH v4 2/5] rk3399: spl: Print SPL banner after relocation Date: Thu, 18 Jun 2020 21:09:45 +0530 Message-Id: <20200618153948.218506-3-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618153948.218506-1-jagan@amarulasolutions.com> References: <20200618153948.218506-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200618_090803_892274_29A3CC9C X-CRM114-Status: GOOD ( 11.53 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:642 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: U-Boot-Denx , linux-rockchip@lists.infradead.org, linux-amarula , Jagan Teki , Suniel Mahesh Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org Usually printing the SPL banner varies between architecture or board codes. - Some would print before relocation at the end board_init_f   for making sure all initialization prior to this would happen   properly. if at all there is a requirement for serial init,   that happens properly since it prints all after that. - Some would print after relocation at the spl_board_init for   making sure all initialization prior to relocation would happen properly. Also debug uart on these cases would be available before relocation. So debug support is available in before and after relocation. Rockchip SPL is following formar step to print the banner at the end of board_init_f. To support various custom use cases in SPL like leds, environment, board detections later options like printing the banner after relocation would be a better option. Printing banner would also help to support debugging availability between relocation codes, like debug uart available before relocation and banner availability after relation. By demonstrating all the above use cases, this patch is trying to print the SPL banner after relocation. Signed-off-by: Jagan Teki Tested-by: Suniel Mahesh --- Changes for v4: - none arch/arm/mach-rockchip/spl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c index d4c83a1119..6d5c058548 100644 --- a/arch/arm/mach-rockchip/spl.c +++ b/arch/arm/mach-rockchip/spl.c @@ -147,7 +147,6 @@ void board_init_f(ulong dummy) gd->ram_top = gd->ram_base + get_effective_memsize(); gd->ram_top = board_get_usable_ram_top(gd->ram_size); #endif - preloader_console_init(); } __weak void rk_spl_board_init(void) @@ -158,6 +157,8 @@ void spl_board_init(void) { /* board specific spl init */ rk_spl_board_init(); + + preloader_console_init(); } #ifdef CONFIG_SPL_LOAD_FIT