[v1] spi: npcm-fiu: Reuse BITS_PER_BYTE definition
diff mbox series

Message ID 20200618170144.57433-1-andriy.shevchenko@linux.intel.com
State Accepted
Commit 0ec544ceb1c1ff65fb5588c6d71bccff2713f0d9
Headers show
  • [v1] spi: npcm-fiu: Reuse BITS_PER_BYTE definition
Related show

Commit Message

Andy Shevchenko June 18, 2020, 5:01 p.m. UTC
No need to redefine already existing definition.
So, replace custom by generic one.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
 drivers/spi/spi-npcm-fiu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


Mark Brown June 19, 2020, 1:28 p.m. UTC | #1
On Thu, 18 Jun 2020 20:01:44 +0300, Andy Shevchenko wrote:
> No need to redefine already existing definition.
> So, replace custom by generic one.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next


[1/1] spi: npcm-fiu: Reuse BITS_PER_BYTE definition
      commit: 0ec544ceb1c1ff65fb5588c6d71bccff2713f0d9

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.


diff mbox series

diff --git a/drivers/spi/spi-npcm-fiu.c b/drivers/spi/spi-npcm-fiu.c
index d25ee32862e0..9468e71f03ad 100644
--- a/drivers/spi/spi-npcm-fiu.c
+++ b/drivers/spi/spi-npcm-fiu.c
@@ -1,6 +1,7 @@ 
 // SPDX-License-Identifier: GPL-2.0
 // Copyright (c) 2019 Nuvoton Technology corporation.
+#include <linux/bits.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
 #include <linux/device.h>
@@ -177,7 +178,6 @@  enum {
 #define MAP_SIZE_16MB			0x1000000
 #define MAP_SIZE_8MB			0x800000
-#define NUM_BITS_IN_BYTE		8
 #define NPCM_MAX_CHIP_NUM		4
 #define CHUNK_SIZE			16
@@ -252,8 +252,8 @@  static void npcm_fiu_set_drd(struct npcm_fiu_spi *fiu,
 	fiu->drd_op.addr.buswidth = op->addr.buswidth;
 	regmap_update_bits(fiu->regmap, NPCM_FIU_DRD_CFG,
-			   ((op->dummy.nbytes * ilog2(op->addr.buswidth))
+			   ((op->dummy.nbytes * ilog2(op->addr.buswidth)) / BITS_PER_BYTE)
 	fiu->drd_op.dummy.nbytes = op->dummy.nbytes;
 	regmap_update_bits(fiu->regmap, NPCM_FIU_DRD_CFG,
 			   NPCM_FIU_DRD_CFG_RDCMD, op->cmd.opcode);