| Message ID | 20200619151938.21740-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/gt: Initialise rps timestamp | expand |
On Fri, 19 Jun 2020 at 16:19, Chris Wilson <chris@chris-wilson.co.uk> wrote: > > Smatch warns that we may iterate over an empty array of gt->engines[]. > One hopes that this is impossible, but nevertheless we can simply > appease smatch by initialising the timestamp to zero before we starting > probing the engines. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c index bdece932592b..296391deeb94 100644 --- a/drivers/gpu/drm/i915/gt/intel_rps.c +++ b/drivers/gpu/drm/i915/gt/intel_rps.c @@ -51,10 +51,11 @@ static void rps_timer(struct timer_list *t) { struct intel_rps *rps = from_timer(rps, t, timer); struct intel_engine_cs *engine; + ktime_t dt, last, timestamp; enum intel_engine_id id; s64 max_busy[3] = {}; - ktime_t dt, timestamp, last; + timestamp = 0; for_each_engine(engine, rps_to_gt(rps), id) { s64 busy; int i; @@ -69,7 +70,6 @@ static void rps_timer(struct timer_list *t) swap(busy, max_busy[i]); } } - last = rps->pm_timestamp; rps->pm_timestamp = timestamp;
Smatch warns that we may iterate over an empty array of gt->engines[]. One hopes that this is impossible, but nevertheless we can simply appease smatch by initialising the timestamp to zero before we starting probing the engines. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/gt/intel_rps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)