mm Add MODULE_DESCRIPTION entries to kernel modules
diff mbox series

Message ID 20200621063101.16260-1-rrobgill@protonmail.com
State New
Headers show
Series
  • mm Add MODULE_DESCRIPTION entries to kernel modules
Related show

Commit Message

Rob Gill June 21, 2020, 6:31 a.m. UTC
The user tool modinfo is used to get information on kernel modules, including a
description where it is available.

This patch adds a brief MODULE_DESCRIPTION to the following kernel modules:

hwpoison-inject
zsmalloc

Signed-off-by: Rob Gill <rrobgill@protonmail.com>
---
 mm/hwpoison-inject.c | 1 +
 mm/zsmalloc.c        | 1 +
 2 files changed, 2 insertions(+)

Comments

David Hildenbrand June 22, 2020, 9 a.m. UTC | #1
On 21.06.20 08:31, Rob Gill wrote:
> The user tool modinfo is used to get information on kernel modules, including a
> description where it is available.
> 
> This patch adds a brief MODULE_DESCRIPTION to the following kernel modules:
> 
> hwpoison-inject
> zsmalloc
> 
> Signed-off-by: Rob Gill <rrobgill@protonmail.com>
> ---
>  mm/hwpoison-inject.c | 1 +
>  mm/zsmalloc.c        | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
> index e488876b1..d506945b6 100644
> --- a/mm/hwpoison-inject.c
> +++ b/mm/hwpoison-inject.c
> @@ -116,3 +116,4 @@ static int pfn_inject_init(void)
>  module_init(pfn_inject_init);
>  module_exit(pfn_inject_exit);
>  MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("hwpoison memory failure injector");
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 952a01e45..eb4d380c2 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -2592,3 +2592,4 @@ module_exit(zs_exit);
>  
>  MODULE_LICENSE("Dual BSD/GPL");
>  MODULE_AUTHOR("Nitin Gupta <ngupta@vflare.org>");
> +MODULE_DESCRIPTION("Slab-based memory allocator for compressed RAM pages");
> 

I would have split this patch up. Also, you should cc the proper
maintainers. See MAINTAINERS and scripts/get_maintainer.pl

Reviewed-by: David Hildenbrand <david@redhat.com>
HORIGUCHI NAOYA(堀口 直也) June 22, 2020, 9:26 a.m. UTC | #2
On Mon, Jun 22, 2020 at 11:00:00AM +0200, David Hildenbrand wrote:
> On 21.06.20 08:31, Rob Gill wrote:
> > The user tool modinfo is used to get information on kernel modules, including a
> > description where it is available.
> > 
> > This patch adds a brief MODULE_DESCRIPTION to the following kernel modules:
> > 
> > hwpoison-inject
> > zsmalloc
> > 
> > Signed-off-by: Rob Gill <rrobgill@protonmail.com>
> > ---
> >  mm/hwpoison-inject.c | 1 +
> >  mm/zsmalloc.c        | 1 +
> >  2 files changed, 2 insertions(+)
> > 
> > diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
> > index e488876b1..d506945b6 100644
> > --- a/mm/hwpoison-inject.c
> > +++ b/mm/hwpoison-inject.c
> > @@ -116,3 +116,4 @@ static int pfn_inject_init(void)
> >  module_init(pfn_inject_init);
> >  module_exit(pfn_inject_exit);
> >  MODULE_LICENSE("GPL");
> > +MODULE_DESCRIPTION("hwpoison memory failure injector");
> > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> > index 952a01e45..eb4d380c2 100644
> > --- a/mm/zsmalloc.c
> > +++ b/mm/zsmalloc.c
> > @@ -2592,3 +2592,4 @@ module_exit(zs_exit);
> >  
> >  MODULE_LICENSE("Dual BSD/GPL");
> >  MODULE_AUTHOR("Nitin Gupta <ngupta@vflare.org>");
> > +MODULE_DESCRIPTION("Slab-based memory allocator for compressed RAM pages");
> > 
> 
> I would have split this patch up. Also, you should cc the proper
> maintainers. See MAINTAINERS and scripts/get_maintainer.pl
> 
> Reviewed-by: David Hildenbrand <david@redhat.com>

Thanks for forwarding, and for mm/hwpoison-inject.c,

Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>

Patch
diff mbox series

diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
index e488876b1..d506945b6 100644
--- a/mm/hwpoison-inject.c
+++ b/mm/hwpoison-inject.c
@@ -116,3 +116,4 @@  static int pfn_inject_init(void)
 module_init(pfn_inject_init);
 module_exit(pfn_inject_exit);
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("hwpoison memory failure injector");
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 952a01e45..eb4d380c2 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -2592,3 +2592,4 @@  module_exit(zs_exit);
 
 MODULE_LICENSE("Dual BSD/GPL");
 MODULE_AUTHOR("Nitin Gupta <ngupta@vflare.org>");
+MODULE_DESCRIPTION("Slab-based memory allocator for compressed RAM pages");