bash-completion: add git-prune into bash completion

Commit Message

Linus Arver via GitGitGadget June 22, 2020, 12:13 a.m. UTC

From: John Lin <[e-mail]>

Sometimes git would suggest the user to run `git prune` when there are
too many unreachable loose objects. It's more user-friendly if we add
git-prune into bash completion.

Signed-off-by: John Lin <[e-mail]>
---
    bash-completion: add git-prune into bash completion
    
    Sometimes git would suggest the user to run git prune when there are too
    many unreachable loose objects. It's more user-friendly if we add
    git-prune into bash completion.
    
    Signed-off-by: John Lin [e-mail] [[e-mail]]
    
    Fixes #642.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-667%2Fjohnlinp%2Fadd-git-prune-bash-completion-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-667/johnlinp/add-git-prune-bash-completion-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/667

 command-list.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 101b3204f37606972b40fc17dec84560c22f69f6

Comments

Junio C Hamano June 22, 2020, 6:28 p.m. UTC | #1

"John Lin via GitGitGadget" <[e-mail]> writes:

> From: John Lin <[e-mail]>
>
> Sometimes git would suggest the user to run `git prune` when there are
> too many unreachable loose objects. It's more user-friendly if we add
> git-prune into bash completion.

Yes, but it does not suggest all the time, and there is a reason.
Most of the time "gc" is more appropriate, but there are narrow
cases where "prune" is more appropriate and that is when the users
will see suggestion to run "prune".

Isn't it too much to type p-r-u-n-e while seeing that message,
typing as you read it?

I do not think it hurts to complete "git prune", in the sense that
we would want to avoid completing potentially destructive operation
to those who do not understand the implications, because the command
is pretty much benign.  But I am not sure it forces users to type
too many keystrokes too frequently that it requires a tab
completion.  I dunno.

Will queue for now.

Thanks.

林自均 July 10, 2020, 1:18 a.m. UTC | #2

Hi Junio,

I saw this integrated into master. Thanks.

Best,
John Lin

Junio C Hamano <[e-mail]> 於 2020年6月23日 週二 上午2:28寫道：
>
> "John Lin via GitGitGadget" <[e-mail]> writes:
>
> > From: John Lin <[e-mail]>
> >
> > Sometimes git would suggest the user to run `git prune` when there are
> > too many unreachable loose objects. It's more user-friendly if we add
> > git-prune into bash completion.
>
> Yes, but it does not suggest all the time, and there is a reason.
> Most of the time "gc" is more appropriate, but there are narrow
> cases where "prune" is more appropriate and that is when the users
> will see suggestion to run "prune".
>
> Isn't it too much to type p-r-u-n-e while seeing that message,
> typing as you read it?
>
> I do not think it hurts to complete "git prune", in the sense that
> we would want to avoid completing potentially destructive operation
> to those who do not understand the implications, because the command
> is pretty much benign.  But I am not sure it forces users to type
> too many keystrokes too frequently that it requires a tab
> completion.  I dunno.
>
> Will queue for now.
>
> Thanks.

Junio C Hamano July 10, 2020, 11:08 p.m. UTC | #3

林自均 <[e-mail]> writes:

> Hi Junio,
>
> I saw this integrated into master. Thanks.

Thank you for writing the patch.

Patch

diff --git a/command-list.txt b/command-list.txt
index cbb960c8436..89aa60cde7e 100644
--- a/command-list.txt
+++ b/command-list.txt
@@ -136,7 +136,7 @@  git-pack-redundant                      plumbinginterrogators
 git-pack-refs                           ancillarymanipulators
 git-parse-remote                        synchelpers
 git-patch-id                            purehelpers
-git-prune                               ancillarymanipulators
+git-prune                               ancillarymanipulators   complete
 git-prune-packed                        plumbingmanipulators
 git-pull                                mainporcelain           remote
 git-push                                mainporcelain           remote