[v18,02/19] checkout: add '\n' to reflog message

Message ID	5210225977366d3673941d2cd75e64565f2b86d6.1592862920.git.gitgitgadget@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=Jtyc=AD=vger.kernel.org=git-owner@kernel.org> Message-Id: <5210225977366d3673941d2cd75e64565f2b86d6.1592862920.git.gitgitgadget@gmail.com> In-Reply-To: <pull.539.v18.git.1592862920.gitgitgadget@gmail.com> References: <pull.539.v17.git.1592335242.gitgitgadget@gmail.com> <pull.539.v18.git.1592862920.gitgitgadget@gmail.com> From: "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> Date: Mon, 22 Jun 2020 21:55:03 +0000 Subject: [PATCH v18 02/19] checkout: add '\n' to reflog message Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: Han-Wen Nienhuys <hanwenn@gmail.com>, Han-Wen Nienhuys <hanwen@google.com> Sender: git-owner@vger.kernel.org Precedence: bulk
Series	Reftable support git-core \| expand [v18,00/19] Reftable support git-core [v18,01/19] lib-t6000.sh: write tag using git-update-ref [v18,02/19] checkout: add '\n' to reflog message [v18,03/19] Write pseudorefs through ref backends. [v18,04/19] Make refs_ref_exists public [v18,05/19] Treat BISECT_HEAD as a pseudo ref [v18,06/19] Treat CHERRY_PICK_HEAD as a pseudo ref [v18,07/19] Treat REVERT_HEAD as a pseudo ref [v18,08/19] Move REF_LOG_ONLY to refs-internal.h [v18,09/19] Iterate over the "refs/" namespace in for_each_[raw]ref [v18,10/19] Add .gitattributes for the reftable/ directory [v18,11/19] Add reftable library [v18,12/19] Add standalone build infrastructure for reftable [v18,13/19] Reftable support for git-core [v18,14/19] Hookup unittests for the reftable library. [v18,15/19] Add GIT_DEBUG_REFS debugging mechanism [v18,16/19] vcxproj: adjust for the reftable changes [v18,17/19] git-prompt: prepare for reftable refs backend [v18,18/19] Add reftable testing infrastructure [v18,19/19] Add "test-tool dump-reftable" command.

Message ID

5210225977366d3673941d2cd75e64565f2b86d6.1592862920.git.gitgitgadget@gmail.com (mailing list archive)

State

New, archived

Headers

Message-Id: 
 <5210225977366d3673941d2cd75e64565f2b86d6.1592862920.git.gitgitgadget@gmail.com>
In-Reply-To: <pull.539.v18.git.1592862920.gitgitgadget@gmail.com>
References: <pull.539.v17.git.1592335242.gitgitgadget@gmail.com>
        <pull.539.v18.git.1592862920.gitgitgadget@gmail.com>
From: "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com>
Date: Mon, 22 Jun 2020 21:55:03 +0000
Subject: [PATCH v18 02/19] checkout: add '\n' to reflog message
Fcc: Sent
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
To: git@vger.kernel.org
Cc: Han-Wen Nienhuys <hanwenn@gmail.com>,
        Han-Wen Nienhuys <hanwen@google.com>
Sender: git-owner@vger.kernel.org
Precedence: bulk

Series

Reftable support git-core | expand

Commit Message

Linus Arver via GitGitGadget June 22, 2020, 9:55 p.m. UTC

From: Han-Wen Nienhuys <hanwen@google.com>

Reftable precisely reproduces the given message. This leads to differences,
because the files backend implicitly adds a trailing '\n' to all messages.

Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
---
 builtin/checkout.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/builtin/checkout.c b/builtin/checkout.c
index af849c644fe..bb11fcc4e99 100644
--- a/builtin/checkout.c
+++ b/builtin/checkout.c
@@ -884,8 +884,9 @@  static void update_refs_for_switch(const struct checkout_opts *opts,
 
 	reflog_msg = getenv("GIT_REFLOG_ACTION");
 	if (!reflog_msg)
-		strbuf_addf(&msg, "checkout: moving from %s to %s",
-			old_desc ? old_desc : "(invalid)", new_branch_info->name);
+		strbuf_addf(&msg, "checkout: moving from %s to %s\n",
+			    old_desc ? old_desc : "(invalid)",
+			    new_branch_info->name);
 	else
 		strbuf_insertstr(&msg, 0, reflog_msg);

[v18,02/19] checkout: add '\n' to reflog message

Commit Message

Patch