[2/2] dt-bindings: sound: add missing clock description of rk3328 DT schema
diff mbox series

Message ID 20200623124734.1736470-2-katsuhiro@katsuster.net
State New
Headers show
Series
  • [1/2] dt-bindings: sound: convert rk3328 codec binding to yaml
Related show

Commit Message

Katsuhiro Suzuki June 23, 2020, 12:47 p.m. UTC
This patch adds description about "mclk" clock and fixes some errors
which are dt_binding_check reported.

Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
---
 .../bindings/sound/rockchip,rk3328-codec.yaml     | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.yaml b/Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.yaml
index 08a74e28e483..525b48c2f5de 100644
--- a/Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.yaml
+++ b/Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.yaml
@@ -19,10 +19,12 @@  properties:
   clocks:
     items:
       - description: clock for audio codec
+      - description: clock for I2S master clock
 
   clock-names:
     items:
       - const: pclk
+      - const: mclk
 
   rockchip,grf:
     $ref: /schemas/types.yaml#/definitions/phandle
@@ -41,21 +43,28 @@  properties:
       GPIO specifier for external line driver control (typically the
       dedicated GPIO_MUTE pin)
 
+  "#sound-dai-cells":
+    const: 0
+
 required:
   - compatible
   - reg
   - clocks
   - clock-names
   - rockchip,grf
+  - "#sound-dai-cells"
 
 examples:
   - |
+    #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/clock/rk3328-cru.h>
     codec: codec@ff410000 {
       compatible = "rockchip,rk3328-codec";
       reg = <0xff410000 0x1000>;
-      clocks = <&cru PCLK_ACODEC>;
-      clock-names = "pclk";
+      clocks = <&cru PCLK_ACODECPHY>, <&cru SCLK_I2S1>;
+      clock-names = "pclk", "mclk";
       rockchip,grf = <&grf>;
       mute-gpios = <&grf_gpio 0 GPIO_ACTIVE_LOW>;
-      spk-depop-time-ms = 100;
+      spk-depop-time-ms = <100>;
+      #sound-dai-cells = <0>;
     };