| Message ID | 20200623133347.4598-1-akshu.agrawal@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: sdhci-acpi: For amd device set driver type as MMC_SET_DRIVER_TYPE_A | expand |
On 23/06/20 4:33 pm, Akshu Agrawal wrote: > HS400/HS200/eMMC HS doesn't have Preset Value register. > Hence, sdhci_set_ios function overrides the value set by fmw to > SDHCI_CTRL_DRV_TYPE_B. > This patch sets drv_type to MMC_SET_DRIVER_TYPE_A > so that host_control2 register gets updated with the required > strength value. > > Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci-acpi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c > index d8b76cb8698a..48ecbd0b180d 100644 > --- a/drivers/mmc/host/sdhci-acpi.c > +++ b/drivers/mmc/host/sdhci-acpi.c > @@ -542,6 +542,7 @@ static int amd_select_drive_strength(struct mmc_card *card, > unsigned int max_dtr, int host_drv, > int card_drv, int *drv_type) > { > + *drv_type = MMC_SET_DRIVER_TYPE_A; > return MMC_SET_DRIVER_TYPE_A; > } > >
On Tue, 23 Jun 2020 at 15:34, Akshu Agrawal <akshu.agrawal@amd.com> wrote: > > HS400/HS200/eMMC HS doesn't have Preset Value register. > Hence, sdhci_set_ios function overrides the value set by fmw to > SDHCI_CTRL_DRV_TYPE_B. > This patch sets drv_type to MMC_SET_DRIVER_TYPE_A > so that host_control2 register gets updated with the required > strength value. > > Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-acpi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c > index d8b76cb8698a..48ecbd0b180d 100644 > --- a/drivers/mmc/host/sdhci-acpi.c > +++ b/drivers/mmc/host/sdhci-acpi.c > @@ -542,6 +542,7 @@ static int amd_select_drive_strength(struct mmc_card *card, > unsigned int max_dtr, int host_drv, > int card_drv, int *drv_type) > { > + *drv_type = MMC_SET_DRIVER_TYPE_A; > return MMC_SET_DRIVER_TYPE_A; > } > > -- > 2.20.1 >
diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c index d8b76cb8698a..48ecbd0b180d 100644 --- a/drivers/mmc/host/sdhci-acpi.c +++ b/drivers/mmc/host/sdhci-acpi.c @@ -542,6 +542,7 @@ static int amd_select_drive_strength(struct mmc_card *card, unsigned int max_dtr, int host_drv, int card_drv, int *drv_type) { + *drv_type = MMC_SET_DRIVER_TYPE_A; return MMC_SET_DRIVER_TYPE_A; }
HS400/HS200/eMMC HS doesn't have Preset Value register. Hence, sdhci_set_ios function overrides the value set by fmw to SDHCI_CTRL_DRV_TYPE_B. This patch sets drv_type to MMC_SET_DRIVER_TYPE_A so that host_control2 register gets updated with the required strength value. Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> --- drivers/mmc/host/sdhci-acpi.c | 1 + 1 file changed, 1 insertion(+)